Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: third_party/WebKit/public/platform/WebPointerProperties.h

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix new instances Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebPointerProperties.h
diff --git a/third_party/WebKit/public/platform/WebPointerProperties.h b/third_party/WebKit/public/platform/WebPointerProperties.h
index 72d6086845149f2c17a62dfc775838a096aa1db9..db82549c54ff6436733d688ba73faa4cccc0700e 100644
--- a/third_party/WebKit/public/platform/WebPointerProperties.h
+++ b/third_party/WebKit/public/platform/WebPointerProperties.h
@@ -5,6 +5,7 @@
#ifndef WebPointerProperties_h
#define WebPointerProperties_h
+#include <cstdint>
#include <limits>
namespace blink {
@@ -17,7 +18,7 @@ namespace blink {
class WebPointerProperties {
public:
WebPointerProperties()
- : button(ButtonNone)
+ : button(Button::NoButton)
, id(0)
, force(std::numeric_limits<float>::quiet_NaN())
, tiltX(0)
@@ -26,14 +27,14 @@ public:
{
}
- enum Button {
- ButtonNone = -1,
- ButtonLeft,
- ButtonMiddle,
- ButtonRight
+ enum class Button : std::int8_t {
+ NoButton = -1,
+ Left,
+ Middle,
+ Right
};
- enum class PointerType : int {
+ enum class PointerType : std::int8_t {
Unknown,
Mouse,
Pen,
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebViewTest.cpp ('k') | third_party/WebKit/public/platform/WebScrollbarBehavior.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698