third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 2227563003: Refactoring button field and its type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix new instances Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index 340521631ad19f081804fb958e67acbb0ae14ad8..c542443721ecc9ea3c9f7e82fa981a181ebd2ffb 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -1853,7 +1853,7 @@ TEST_F(WebViewTest, BlinkCaretOnClosingContextMenu)

// Note that we do not send MouseUp event here since it will be consumed

// by the context menu once it shows up.

WebMouseEvent mouseEvent;

- mouseEvent.button = WebMouseEvent::ButtonRight;

+ mouseEvent.button = WebMouseEvent::Button::Right;

mouseEvent.x = 1;

mouseEvent.y = 1;

mouseEvent.clickCount = 1;

@@ -2855,7 +2855,7 @@ TEST_F(WebViewTest, FirstUserGestureObservedMouseEvent)

EXPECT_EQ(0, client.getUserGestureNotificationsCount());

WebMouseEvent mouseEvent;

- mouseEvent.button = WebMouseEvent::ButtonLeft;

+ mouseEvent.button = WebMouseEvent::Button::Left;

mouseEvent.x = 1;

mouseEvent.y = 1;

mouseEvent.clickCount = 1;