third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp - Issue 2227563003: Refactoring button field and its type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix mac/win errors Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/events/PointerEventFactory.cpp ('K') | « third_party/WebKit/Source/core/html/forms/RangeInputType.cpp ('k') | third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

index ba40ba127b1bf9313fe7ab24b1d649b9fe5045ca..bf8c0459b928958e840e38807573a6dc315950ad 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

@@ -572,7 +572,7 @@ MediaControlTimelineElement* MediaControlTimelineElement::create(MediaControls&

void MediaControlTimelineElement::defaultEventHandler(Event* event)

{

- if (event->isMouseEvent() && toMouseEvent(event)->button() != LeftButton)

+ if (event->isMouseEvent() && toMouseEvent(event)->button() != static_cast<short>(WebPointerProperties::Button::Left))

return;

if (!isConnected() || !document().isActive())

@@ -652,7 +652,7 @@ MediaControlVolumeSliderElement* MediaControlVolumeSliderElement::create(MediaCo

void MediaControlVolumeSliderElement::defaultEventHandler(Event* event)

{

- if (event->isMouseEvent() && toMouseEvent(event)->button() != LeftButton)

+ if (event->isMouseEvent() && toMouseEvent(event)->button() != static_cast<short>(WebPointerProperties::Button::Left))

return;

if (!isConnected() || !document().isActive())