third_party/WebKit/Source/core/html/forms/RangeInputType.cpp - Issue 2227563003: Refactoring button field and its type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix mac/win errors Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

index e91b6744e21b01b7d9fde5abab14d158326bc22a..99734bd5547b0238af4bcdb2e3335dc97b336e15 100644

--- a/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

@@ -157,7 +157,7 @@ void RangeInputType::handleMouseDownEvent(MouseEvent* event)

return;

Node* targetNode = event->target()->toNode();

- if (event->button() != LeftButton || !targetNode)

+ if (event->button() != static_cast<short>(WebPointerProperties::Button::Left) || !targetNode)

return;

DCHECK(element().shadow());

if (targetNode != element() && !targetNode->isDescendantOf(element().userAgentShadowRoot()))