Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7667)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 2227513002: MacViews: Reposition permission bubble on browser resize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment to parentWindowDidResize. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index 22505764c11a0f1aa08e91d4529dd056279a0674..ba1e1745c44ccdcdd2291e70610440d7bf47067a 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -269,9 +269,7 @@ - (void)layoutSubviews {
// Will update the location of the permission bubble when showing/hiding the
// top level toolbar in fullscreen.
- PermissionRequestManager* manager = [self permissionRequestManager];
- if (manager)
- manager->UpdateAnchorPosition();
+ [self updatePermissionBubbleAnchor];
browser_->GetBubbleManager()->UpdateAllBubbleAnchors();
}
@@ -421,10 +419,8 @@ - (void)moveViewsForImmersiveFullscreen:(BOOL)fullscreen
if (statusBubble_)
statusBubble_->SwitchParentWindow(destWindow);
- // Updates the bubble position.
- PermissionRequestManager* manager = [self permissionRequestManager];
- if (manager)
- manager->UpdateAnchorPosition();
+ // Updates the permission bubble position.
tapted 2016/08/10 01:27:20 nit: this comment is obsolete with the method comm
karandeepb 2016/08/10 04:00:43 Done.
+ [self updatePermissionBubbleAnchor];
// Move the title over.
[destWindow setTitle:[sourceWindow title]];
@@ -462,6 +458,12 @@ - (void)permissionBubbleWindowWillClose:(NSNotification*)notification {
delay:YES];
}
+- (void)updatePermissionBubbleAnchor {
+ PermissionRequestManager* manager = [self permissionRequestManager];
+ if (manager)
+ manager->UpdateAnchorPosition();
+}
+
- (void)configureFullscreenToolbarController {
BOOL fullscreenForTab = [self isFullscreenForTabContentOrExtension];
BOOL kioskMode =

Powered by Google App Engine
This is Rietveld 408576698