MacViews: Reposition permission bubble on browser resize.

chrome/browser/ui/cocoa/browser_window_controller_private.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h"
 
 #include <cmath>
 
 #import "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 251 matching lines @@
 
   base::scoped_nsobject<BrowserWindowLayout> layout(
       [[BrowserWindowLayout alloc] init]);
   [self updateLayoutParameters:layout];
   [self applyLayout:layout];
 
   [toolbarController_ setDividerOpacity:[self toolbarDividerOpacity]];
 
   // Will update the location of the permission bubble when showing/hiding the
   // top level toolbar in fullscreen.
-  PermissionRequestManager* manager = [self permissionRequestManager];
-  if (manager)
-    manager->UpdateAnchorPosition();
+  [self updatePermissionBubbleAnchor];
 
   browser_->GetBubbleManager()->UpdateAllBubbleAnchors();
 }
 
 - (void)applyTabStripLayout:(const chrome::TabStripLayout&)layout {
   // Update the presence of the window controls.
   if (layout.addCustomWindowControls)
     [tabStripController_ addCustomWindowControls];
   else
     [tabStripController_ removeCustomWindowControls];
@@ skipping 129 matching lines @@
     [[destWindow contentView] addSubview:tabStripView];
 
   [sourceWindow setWindowController:nil];
   [self setWindow:destWindow];
   [destWindow setWindowController:self];
 
   // Move the status bubble over, if we have one.
   if (statusBubble_)
     statusBubble_->SwitchParentWindow(destWindow);
 
-  // Updates the bubble position.
-  PermissionRequestManager* manager = [self permissionRequestManager];
-  if (manager)
-    manager->UpdateAnchorPosition();
+  // Updates the permission bubble position.

[tapted, 2016/08/10 01:27:20]

nit: this comment is obsolete with the method comment for
updatePermissionBubbleAnchor];

[karandeepb, 2016/08/10 04:00:43]

Done.

+  [self updatePermissionBubbleAnchor];
 
   // Move the title over.
   [destWindow setTitle:[sourceWindow title]];
 
   // The window needs to be onscreen before we can set its first responder.
   // Ordering the window to the front can change the active Space (either to
   // the window's old Space or to the application's assigned Space). To prevent
   // this by temporarily change the collectionBehavior.
   NSWindowCollectionBehavior behavior = [sourceWindow collectionBehavior];
   [destWindow setCollectionBehavior:
@@ skipping 17 matching lines @@
 - (void)permissionBubbleWindowWillClose:(NSNotification*)notification {
   NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
   [center removeObserver:self
                     name:NSWindowWillCloseNotification
                   object:[notification object]];
   [self releaseBarVisibilityForOwner:[notification object]
                        withAnimation:YES
                                delay:YES];
 }
 
+- (void)updatePermissionBubbleAnchor {
+  PermissionRequestManager* manager = [self permissionRequestManager];
+  if (manager)
+    manager->UpdateAnchorPosition();
+}
+
 - (void)configureFullscreenToolbarController {
   BOOL fullscreenForTab = [self isFullscreenForTabContentOrExtension];
   BOOL kioskMode =
       base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kKioskMode);
   BOOL showDropdown =
       !fullscreenForTab && !kioskMode && ([self floatingBarHasFocus]);
 
   PermissionRequestManager* manager = [self permissionRequestManager];
   if (manager && manager->IsBubbleVisible()) {
     NSWindow* bubbleWindow = manager->GetBubbleWindow();
@@ skipping 822 matching lines @@
   if (fullscreenLowPowerCoordinator_)
     fullscreenLowPowerCoordinator_->SetHasActiveSheet(false);
 }
 
 - (void)childWindowsDidChange {
   if (fullscreenLowPowerCoordinator_)
     fullscreenLowPowerCoordinator_->ChildWindowsChanged();
 }
 
 @end  // @implementation BrowserWindowController(Private)