chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm - Issue 2227513002: MacViews: Reposition permission bubble on browser resize.

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

Issue 2227513002: MacViews: Reposition permission bubble on browser resize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

index d9908715febc7856d23c78e330f52e9d8d320202..4801a2b7bdf60c52e7327b7bce3af628ccbad467 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

@@ -300,8 +300,8 @@ - (void)parentWindowWillToggleFullScreen:(NSNotification*)notification {

}

- (void)parentWindowDidResize:(NSNotification*)notification {

tapted 2016/08/08 07:10:18 we can just delete this - it's overriding a "priva

karandeepb 2016/08/08 10:37:29 Wouldn't that make a call to the base class versio

tapted 2016/08/09 01:58:39 Ah, yeh there might be a race depending on observe

karandeepb 2016/08/09 07:51:32 Done.

- DCHECK(bridge_);

- [self updateAnchorPosition];

+ // It's not necessary to call updateAnchorPosition since

+ // BrowserWindowController will do that.

}

- (void)parentWindowDidMove:(NSNotification*)notification {

« chrome/browser/ui/cocoa/browser_window_controller.mm ('K') | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | no next file » | no next file with comments »