MacViews: Reposition permission bubble on browser resize.

chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h"
 
 #include <algorithm>
 
 #include "base/mac/bind_objc_block.h"
 #include "base/macros.h"
@@ skipping 281 matching lines @@
                 name:NSWindowDidMoveNotification
               object:nil];
   bridge_->OnBubbleClosing();
   [super windowWillClose:notification];
 }
 
 - (void)parentWindowWillToggleFullScreen:(NSNotification*)notification {
   // Override the base class implementation, which would have closed the bubble.
 }
 
 - (void)parentWindowDidResize:(NSNotification*)notification {

[tapted, 2016/08/08 07:10:18]

we can just delete this - it's overriding a "private" method of
BaseBubbleController anyway - ick

[karandeepb, 2016/08/08 10:37:29]

Wouldn't that make a call to the base class version and we probably don't want
that. Although there are no "observable" differences in behavior on removing
this.

[tapted, 2016/08/09 01:58:39]

Ah, yeh there might be a race depending on observer order. Let's also make it
clear we're overriding the base class implementation (like
parentWindowWillToggleFullScreen:) 

[karandeepb, 2016/08/09 07:51:32]

Done.

-  DCHECK(bridge_);
-  [self updateAnchorPosition];
+  // It's not necessary to call updateAnchorPosition since
+  // BrowserWindowController will do that.
 }
 
 - (void)parentWindowDidMove:(NSNotification*)notification {
   DCHECK(bridge_);
   [self setAnchorPoint:[self getExpectedAnchorPoint]];
 }
 
 - (void)showWithDelegate:(PermissionPrompt::Delegate*)delegate
              forRequests:(const std::vector<PermissionRequest*>&)requests
             acceptStates:(const std::vector<bool>&)acceptStates {
@@ skipping 323 matching lines @@
 
 + (void)alignCenterOf:(NSView*)viewA verticallyToCenterOf:(NSView*)viewB {
   NSRect frameA = [viewA frame];
   NSRect frameB = [viewB frame];
   frameA.origin.y =
       NSMinY(frameB) + std::floor((NSHeight(frameB) - NSHeight(frameA)) / 2);
   [viewA setFrameOrigin:frameA.origin];
 }
 
 @end  // implementation PermissionBubbleController