Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 222743004: cc: Avoid dynamic calls to base::Bind in scheduler (Closed)

Created:
6 years, 8 months ago by brianderson
Modified:
6 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, danakj
Base URL:
http://git.chromium.org/chromium/src.git@pollForCommit3
Visibility:
Public.

Description

cc: Avoid dynamic calls to base::Bind in scheduler BUG=359245 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261668

Patch Set 1 #

Patch Set 2 : rebase on bo's patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -32 lines) Patch
M cc/scheduler/scheduler.h View 1 2 chunks +8 lines, -4 lines 0 comments Download
M cc/scheduler/scheduler.cc View 1 9 chunks +29 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
brianderson
ptal, depends on https://codereview.chromium.org/222003007
6 years, 8 months ago (2014-04-02 20:55:36 UTC) #1
tomhudson
Awesome, it sounds like this ought to have a measurable impact on (Android?) performance.
6 years, 8 months ago (2014-04-03 11:36:40 UTC) #2
danakj
LGTM
6 years, 8 months ago (2014-04-03 14:18:00 UTC) #3
Sami
lgtm
6 years, 8 months ago (2014-04-03 15:16:19 UTC) #4
brianderson
On 2014/04/03 11:36:40, tomhudson wrote: > Awesome, it sounds like this ought to have a ...
6 years, 8 months ago (2014-04-03 18:32:25 UTC) #5
brianderson
The CQ bit was checked by brianderson@chromium.org
6 years, 8 months ago (2014-04-04 00:02:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/222743004/20001
6 years, 8 months ago (2014-04-04 00:02:21 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 04:34:30 UTC) #8
Message was sent while issue was closed.
Change committed as 261668

Powered by Google App Engine
This is Rietveld 408576698