cc: Advance commit state with a CancelableClosure

cc: Advance commit state with a CancelableClosure

This also makes testing more straightforward since
we can use a TestTaskRunner to query and run posted
tasks directly.

BUG=359245
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261582

[brianderson, 2014-04-02 20:40:45]

ptal

[danakj, 2014-04-03 14:17:58]

LGTM

[Sami, 2014-04-03 15:15:01]

https://codereview.chromium.org/222003007/diff/1/cc/scheduler/scheduler_unitt...
File cc/scheduler/scheduler_unittest.cc (right):

https://codereview.chromium.org/222003007/diff/1/cc/scheduler/scheduler_unitt...
cc/scheduler/scheduler_unittest.cc:1280: settings.throttle_frame_production =
true;
Does the test no longer require this setting?

nit: Could make this just "SchedulerSettings default_scheduler_settings;" like
in the other tests since this is the default.

[brianderson, 2014-04-03 16:18:31]

https://codereview.chromium.org/222003007/diff/1/cc/scheduler/scheduler_unitt...
File cc/scheduler/scheduler_unittest.cc (right):

https://codereview.chromium.org/222003007/diff/1/cc/scheduler/scheduler_unitt...
cc/scheduler/scheduler_unittest.cc:1280: settings.throttle_frame_production =
true;
On 2014/04/03 15:15:01, Sami wrote:
> Does the test no longer require this setting?
> 
> nit: Could make this just "SchedulerSettings default_scheduler_settings;" like
> in the other tests since this is the default.

I'll use the default settings for this test.

The test doesn't depend on vsync being enabled or disabled since it's just
trying to check that the scheduler polls to advance the commit state while a
BeginMainFrame is pending.

Disabling it allows this test to look for an explicit posted task delay of twice
the display interval, especially in later patches where the scheduler posts it's
own tasks when vsync is disabled.

[Sami, 2014-04-03 17:44:23]

On 2014/04/03 16:18:31, brianderson wrote:
> I'll use the default settings for this test.
> 
> The test doesn't depend on vsync being enabled or disabled since it's just
> trying to check that the scheduler polls to advance the commit state while a
> BeginMainFrame is pending.
> 
> Disabling it allows this test to look for an explicit posted task delay of
twice
> the display interval, especially in later patches where the scheduler posts
it's
> own tasks when vsync is disabled.

Great, thanks for the explanation. lgtm.

[brianderson, 2014-04-03 20:03:59]

The CQ bit was checked by brianderson@chromium.org

[commit-bot: I haz the power, 2014-04-03 20:21:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/brianderson@chromium.org/222003007/20001

[commit-bot: I haz the power, 2014-04-03 23:55:34]

Change committed as 261582