Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2227293002: Add RAIL tracing category to Chrome tracing. (Closed)

Created:
4 years, 4 months ago by alexandermont
Modified:
4 years, 4 months ago
CC:
ajuma+watch_chromium.org, darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, dtapuska+chromiumwatch_chromium.org, Eric Willigers, feature-media-reviews_chromium.org, f(malita), jam, jbroman, Justin Novosad, kinuko+watch, mlamouri+watch-content_chromium.org, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add RAIL tracing category to Chrome tracing. Adds an additional rail tracing category, which includes each event that is needed to generate rail stages in the trace. The purpose of this change is to allow metrics to access rail stage information while minimizing the size of the traces. TBR=caseq@chromium.org, dalecurtis@chromium.org BUG=636442 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/cd6ea329d3c2657c97e34ca24814779eb80b384a Cr-Commit-Position: refs/heads/master@{#411687}

Patch Set 1 #

Patch Set 2 : fix line length and add more rail events #

Patch Set 3 : add missing PaintTiming markers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -58 lines) Patch
M cc/debug/benchmark_instrumentation.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/app/content_main_runner.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_manager.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/input/render_widget_input_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 14 chunks +24 lines, -21 lines 0 comments Download
M media/blink/video_frame_compositor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentTiming.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/PageAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintTiming.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/events/latency_info.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 33 (16 generated)
alexandermont
4 years, 4 months ago (2016-08-09 23:27:17 UTC) #3
Ken Russell (switch to Gerrit)
DrawingBuffer lgtm
4 years, 4 months ago (2016-08-10 00:55:24 UTC) #5
charliea (OOO until 10-5)
non-owner lgtm
4 years, 4 months ago (2016-08-10 15:37:38 UTC) #6
Ken Russell (switch to Gerrit)
Note: I suggested to Alexander to TBR= the remaining changes since these changes are trivial, ...
4 years, 4 months ago (2016-08-10 18:12:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227293002/1
4 years, 4 months ago (2016-08-10 18:16:17 UTC) #10
DaleCurtis
media/ lgtm
4 years, 4 months ago (2016-08-10 19:07:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/259502)
4 years, 4 months ago (2016-08-10 20:35:25 UTC) #14
Ken Russell (switch to Gerrit)
On 2016/08/10 20:35:25, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 4 months ago (2016-08-10 20:56:35 UTC) #15
caseq
lgtm
4 years, 4 months ago (2016-08-10 22:35:03 UTC) #16
alexandermont
4 years, 4 months ago (2016-08-11 17:01:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227293002/20001
4 years, 4 months ago (2016-08-11 17:02:12 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/276184)
4 years, 4 months ago (2016-08-11 18:24:14 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227293002/40001
4 years, 4 months ago (2016-08-11 21:50:35 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/50780)
4 years, 4 months ago (2016-08-11 22:06:08 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227293002/40001
4 years, 4 months ago (2016-08-12 16:34:00 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-12 17:24:25 UTC) #31
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 17:27:00 UTC) #33
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cd6ea329d3c2657c97e34ca24814779eb80b384a
Cr-Commit-Position: refs/heads/master@{#411687}

Powered by Google App Engine
This is Rietveld 408576698