Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2227203002: [interpreter] Logically separate hole-checking and const assignment errors (Closed)

Created:
4 years, 4 months ago by adamk
Modified:
4 years, 4 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Logically separate hole-checking and const assignment errors In addition, make use of Variable::binding_needs_init() in addition to VariableMode when deciding whether to do hole checking in variable assignment. R=rmcilroy@chromium.org Committed: https://crrev.com/680ae2c00146124291ba56d991860212a97f3fe0 Cr-Commit-Position: refs/heads/master@{#38555}

Patch Set 1 #

Patch Set 2 : Remove unused var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -53 lines) Patch
M src/interpreter/bytecode-generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 6 chunks +29 lines, -42 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ConstVariable.golden View 4 chunks +3 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden View 4 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
adamk
4 years, 4 months ago (2016-08-09 22:19:50 UTC) #1
rmcilroy
LGTM, thanks.
4 years, 4 months ago (2016-08-10 11:39:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227203002/20001
4 years, 4 months ago (2016-08-10 17:30:57 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 17:32:48 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 17:32:48 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/680ae2c00146124291ba56d991860212a97f3fe0
Cr-Commit-Position: refs/heads/master@{#38555}

Powered by Google App Engine
This is Rietveld 408576698