Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: chrome/browser/extensions/api/declarative_content/content_action.cc

Issue 2227193002: Make UserScript non-copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove browser/renderer specific file impl as it is not helping much Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_content/content_action.cc
diff --git a/chrome/browser/extensions/api/declarative_content/content_action.cc b/chrome/browser/extensions/api/declarative_content/content_action.cc
index 72d2aaa7db18d59a9099bf7428d3082fbc60afed..a526c355da1e1a50e5a4e0be4692834bcab5ccf9 100644
--- a/chrome/browser/extensions/api/declarative_content/content_action.cc
+++ b/chrome/browser/extensions/api/declarative_content/content_action.cc
@@ -331,7 +331,7 @@ RequestContentScript::RequestContentScript(
RequestContentScript::~RequestContentScript() {
DCHECK(master_);
- master_->RemoveScript(script_);
+ master_->RemoveScript(UserScriptIDPair(script_.id(), script_.host_id()));
}
void RequestContentScript::InitScript(const HostID& host_id,
@@ -347,19 +347,24 @@ void RequestContentScript::InitScript(const HostID& host_id,
it != script_data.css_file_names.end(); ++it) {
GURL url = extension->GetResourceURL(*it);
ExtensionResource resource = extension->GetResource(*it);
- script_.css_scripts().push_back(UserScript::File(
- resource.extension_root(), resource.relative_path(), url));
+ script_.css_scripts().push_back(base::WrapUnique(new UserScript::File(
Devlin 2016/08/17 16:39:30 nitty nit: I think we came to a semi-consensus to
lazyboy 2016/08/17 18:55:52 Done.
+ resource.extension_root(), resource.relative_path(), url)));
}
for (std::vector<std::string>::const_iterator it =
script_data.js_file_names.begin();
it != script_data.js_file_names.end(); ++it) {
GURL url = extension->GetResourceURL(*it);
ExtensionResource resource = extension->GetResource(*it);
- script_.js_scripts().push_back(UserScript::File(
- resource.extension_root(), resource.relative_path(), url));
+ script_.js_scripts().push_back(base::WrapUnique(new UserScript::File(
+ resource.extension_root(), resource.relative_path(), url)));
}
}
+void RequestContentScript::AddScript() {
+ DCHECK(master_);
+ master_->AddScript(UserScript::CopyFrom(script_));
+}
+
void RequestContentScript::Apply(const ApplyInfo& apply_info) const {
InstructRenderProcessToInject(apply_info.tab, apply_info.extension);
}

Powered by Google App Engine
This is Rietveld 408576698