Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: chrome/browser/chromeos/accessibility/accessibility_manager.cc

Issue 2227193002: Make UserScript non-copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove browser/renderer specific file impl as it is not helping much Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/accessibility/accessibility_manager.cc
diff --git a/chrome/browser/chromeos/accessibility/accessibility_manager.cc b/chrome/browser/chromeos/accessibility/accessibility_manager.cc
index 9039d729aa36004dc2703c1e26cef0d8a31ff4f0..2918643dc9cf774336f19e9a289f27fb1a6e26de 100644
--- a/chrome/browser/chromeos/accessibility/accessibility_manager.cc
+++ b/chrome/browser/chromeos/accessibility/accessibility_manager.cc
@@ -265,14 +265,15 @@ void InjectChromeVoxContentScript(
const extensions::UserScriptList& content_scripts =
extensions::ContentScriptsInfo::GetContentScripts(extension);
- for (size_t i = 0; i < content_scripts.size(); i++) {
- const extensions::UserScript& script = content_scripts[i];
- if (web_contents && !script.MatchesURL(content_url))
+ for (const std::unique_ptr<extensions::UserScript>& script :
+ content_scripts) {
+ if (web_contents && !script->MatchesURL(content_url))
continue;
- for (size_t j = 0; j < script.js_scripts().size(); ++j) {
- const extensions::UserScript::File& file = script.js_scripts()[j];
- extensions::ExtensionResource resource = extension->GetResource(
- file.relative_path());
+ for (size_t j = 0; j < script->js_scripts().size(); ++j) {
+ const std::unique_ptr<extensions::UserScriptFile>& file =
Devlin 2016/08/17 16:39:30 nit: maybe update this to range-based for loop, to
lazyboy 2016/08/17 18:55:51 Done.
+ script->js_scripts()[j];
+ extensions::ExtensionResource resource =
+ extension->GetResource(file->relative_path());
loader->AppendScript(resource);
}
}

Powered by Google App Engine
This is Rietveld 408576698