mash: Move AutoHideEventHandler to WmShelfAura.

mash: Move AutoHideEventHandler to WmShelfAura.

Manage an AutoHideEventHandler instance in WmShelfAura.
Send the target window to UpdateAutoHideFor*Event.
Move in_mouse_drag_ to ShelfLayoutManager.

Remove WmShelf::UpdateAutoHideFor*Event helpers.
Remove shelf/status Widget event handler overrides.
(this disables auto-hide for mash, needs implementation)
(partly reverts https://codereview.chromium.org/2109193002)

BUG=615155, 621112, 631216
TEST=Automated; no auto-hide changes in non-mash ChromeOS.
R=jamescook@chromium.org

Committed: https://crrev.com/e2dd2245e3707d5ff18b3186192f00253c04598f
Cr-Commit-Position: refs/heads/master@{#410813}

[msw, 2016-08-09 19:13:00]

Description was changed from

==========
mash: Move AutoHideEventHandler to WmShelfAura.

BUG=615155,621112
==========

to

==========
mash: Move AutoHideEventHandler to WmShelfAura.

Manage an AutoHideEventHandler instance in WmShelfAura.
Send the target window to UpdateAutoHideFor*Event.
Move in_mouse_drag_ to ShelfLayoutManager.

Remove WmShelf::UpdateAutoHideFor*Event helpers.
Remove shelf/status Widget event handler overrides.
(this disables auto-hide for mash, needs implementation)
(partly reverts https://codereview.chromium.org/2109193002)

BUG=615155,621112
TEST=Automated; no auto-hide changes in non-mash ChromeOS.
R=jamescook@chromium.org
==========

[msw, 2016-08-09 19:13:00]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-08-09 19:17:51]

Hey James, please take a look; thanks!

[msw, 2016-08-09 19:21:05]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 19:21:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-08-09 19:26:12]

Description was changed from

==========
mash: Move AutoHideEventHandler to WmShelfAura.

Manage an AutoHideEventHandler instance in WmShelfAura.
Send the target window to UpdateAutoHideFor*Event.
Move in_mouse_drag_ to ShelfLayoutManager.

Remove WmShelf::UpdateAutoHideFor*Event helpers.
Remove shelf/status Widget event handler overrides.
(this disables auto-hide for mash, needs implementation)
(partly reverts https://codereview.chromium.org/2109193002)

BUG=615155,621112
TEST=Automated; no auto-hide changes in non-mash ChromeOS.
R=jamescook@chromium.org
==========

to

==========
mash: Move AutoHideEventHandler to WmShelfAura.

Manage an AutoHideEventHandler instance in WmShelfAura.
Send the target window to UpdateAutoHideFor*Event.
Move in_mouse_drag_ to ShelfLayoutManager.

Remove WmShelf::UpdateAutoHideFor*Event helpers.
Remove shelf/status Widget event handler overrides.
(this disables auto-hide for mash, needs implementation)
(partly reverts https://codereview.chromium.org/2109193002)

BUG=615155,621112,631216
TEST=Automated; no auto-hide changes in non-mash ChromeOS.
R=jamescook@chromium.org
==========

[James Cook, 2016-08-09 19:47:58]

A couple questions.

https://codereview.chromium.org/2227143003/diff/20001/ash/common/shelf/wm_she...
File ash/common/shelf/wm_shelf.h (left):

https://codereview.chromium.org/2227143003/diff/20001/ash/common/shelf/wm_she...
ash/common/shelf/wm_shelf.h:17: class MouseEvent;
You're so good about cleaning up stuff like this.

https://codereview.chromium.org/2227143003/diff/20001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2227143003/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:934: if (in_mouse_drag_)
Just to double-check: This function is already checking at the top to ensure the
visibility_state is SHELF_AUTO_HIDE, which is equivalent to the old code's check
for the existence of the event filter?

https://codereview.chromium.org/2227143003/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:987:
WmLookup::Get()->GetWindowForWidget(shelf_widget_->status_area_widget());
It seems like this function should either check for a null shelf_widget_ here,
or if it cannot be null, not check |shelf_window| below.

https://codereview.chromium.org/2227143003/diff/20001/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (left):

https://codereview.chromium.org/2227143003/diff/20001/ash/shelf/shelf_widget....
ash/shelf/shelf_widget.cc:25: #include "ash/shell.h"
Hooray!

[msw, 2016-08-09 19:52:58]

Please take another look; thanks!

https://codereview.chromium.org/2227143003/diff/20001/ash/common/shelf/wm_she...
File ash/common/shelf/wm_shelf.h (left):

https://codereview.chromium.org/2227143003/diff/20001/ash/common/shelf/wm_she...
ash/common/shelf/wm_shelf.h:17: class MouseEvent;
On 2016/08/09 19:47:58, James Cook wrote:
> You're so good about cleaning up stuff like this.

Acknowledged.

https://codereview.chromium.org/2227143003/diff/20001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2227143003/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:934: if (in_mouse_drag_)
On 2016/08/09 19:47:58, James Cook wrote:
> Just to double-check: This function is already checking at the top to ensure
the
> visibility_state is SHELF_AUTO_HIDE, which is equivalent to the old code's
check
> for the existence of the event filter?

Yup, I went to add a |visibility_state == SHELF_AUTO_HIDE| check here, but saw
the check at the top of the function and then decided to skip a redundant check.
I'm willing to add one if you prefer.

https://codereview.chromium.org/2227143003/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:987:
WmLookup::Get()->GetWindowForWidget(shelf_widget_->status_area_widget());
On 2016/08/09 19:47:58, James Cook wrote:
> It seems like this function should either check for a null shelf_widget_ here,
> or if it cannot be null, not check |shelf_window| below.

Ah yeah, good call.

https://codereview.chromium.org/2227143003/diff/20001/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (left):

https://codereview.chromium.org/2227143003/diff/20001/ash/shelf/shelf_widget....
ash/shelf/shelf_widget.cc:25: #include "ash/shell.h"
On 2016/08/09 19:47:58, James Cook wrote:
> Hooray!

Acknowledged.

[James Cook, 2016-08-09 19:54:29]

LGTM

https://codereview.chromium.org/2227143003/diff/20001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2227143003/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:934: if (in_mouse_drag_)
On 2016/08/09 19:52:58, msw wrote:
> On 2016/08/09 19:47:58, James Cook wrote:
> > Just to double-check: This function is already checking at the top to ensure
> the
> > visibility_state is SHELF_AUTO_HIDE, which is equivalent to the old code's
> check
> > for the existence of the event filter?
> 
> Yup, I went to add a |visibility_state == SHELF_AUTO_HIDE| check here, but saw
> the check at the top of the function and then decided to skip a redundant
check.
> I'm willing to add one if you prefer.

Nope, this is fine.

[msw, 2016-08-09 19:56:06]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-08-09 19:56:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 20:00:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 20:00:52]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[msw, 2016-08-09 20:06:29]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-09 20:06:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2227143003/#ps60001
(title: "Sync and rebase.")

[commit-bot: I haz the power, 2016-08-09 20:07:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 20:53:49]

Description was changed from

==========
mash: Move AutoHideEventHandler to WmShelfAura.

Manage an AutoHideEventHandler instance in WmShelfAura.
Send the target window to UpdateAutoHideFor*Event.
Move in_mouse_drag_ to ShelfLayoutManager.

Remove WmShelf::UpdateAutoHideFor*Event helpers.
Remove shelf/status Widget event handler overrides.
(this disables auto-hide for mash, needs implementation)
(partly reverts https://codereview.chromium.org/2109193002)

BUG=615155,621112,631216
TEST=Automated; no auto-hide changes in non-mash ChromeOS.
R=jamescook@chromium.org
==========

to

==========
mash: Move AutoHideEventHandler to WmShelfAura.

Manage an AutoHideEventHandler instance in WmShelfAura.
Send the target window to UpdateAutoHideFor*Event.
Move in_mouse_drag_ to ShelfLayoutManager.

Remove WmShelf::UpdateAutoHideFor*Event helpers.
Remove shelf/status Widget event handler overrides.
(this disables auto-hide for mash, needs implementation)
(partly reverts https://codereview.chromium.org/2109193002)

BUG=615155,621112,631216
TEST=Automated; no auto-hide changes in non-mash ChromeOS.
R=jamescook@chromium.org
==========

[commit-bot: I haz the power, 2016-08-09 20:53:50]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-09 20:57:09]

Description was changed from

==========
mash: Move AutoHideEventHandler to WmShelfAura.

Manage an AutoHideEventHandler instance in WmShelfAura.
Send the target window to UpdateAutoHideFor*Event.
Move in_mouse_drag_ to ShelfLayoutManager.

Remove WmShelf::UpdateAutoHideFor*Event helpers.
Remove shelf/status Widget event handler overrides.
(this disables auto-hide for mash, needs implementation)
(partly reverts https://codereview.chromium.org/2109193002)

BUG=615155,621112,631216
TEST=Automated; no auto-hide changes in non-mash ChromeOS.
R=jamescook@chromium.org
==========

to

==========
mash: Move AutoHideEventHandler to WmShelfAura.

Manage an AutoHideEventHandler instance in WmShelfAura.
Send the target window to UpdateAutoHideFor*Event.
Move in_mouse_drag_ to ShelfLayoutManager.

Remove WmShelf::UpdateAutoHideFor*Event helpers.
Remove shelf/status Widget event handler overrides.
(this disables auto-hide for mash, needs implementation)
(partly reverts https://codereview.chromium.org/2109193002)

BUG=615155,621112,631216
TEST=Automated; no auto-hide changes in non-mash ChromeOS.
R=jamescook@chromium.org

Committed: https://crrev.com/e2dd2245e3707d5ff18b3186192f00253c04598f
Cr-Commit-Position: refs/heads/master@{#410813}
==========

[commit-bot: I haz the power, 2016-08-09 20:57:10]

Patchset 4 (id:??) landed as
https://crrev.com/e2dd2245e3707d5ff18b3186192f00253c04598f
Cr-Commit-Position: refs/heads/master@{#410813}