Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2109193002: mash: Convert StatusAreaWidgetDelegate to wm common types (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Convert StatusAreaWidgetDelegate to wm common types This is a dependency of StatusAreaWidget. BUG=619636 TEST=ash_unittests Committed: https://crrev.com/ba93d044cec883e554ec76c7d463d3ba915eab26 Cr-Commit-Position: refs/heads/master@{#402941}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -319 lines) Patch
M ash/ash.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/aura/wm_shelf_aura.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ash/aura/wm_shelf_aura.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/common/shelf/wm_shelf.h View 1 chunk +7 lines, -0 lines 0 comments Download
A + ash/common/system/status_area_widget_delegate.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + ash/common/system/status_area_widget_delegate.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M ash/focus_cycler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/bridge/wm_shelf_mus.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/mus/bridge/wm_shelf_mus.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/system/status_area_widget.cc View 2 chunks +1 line, -1 line 0 comments Download
D ash/system/status_area_widget_delegate.h View 1 chunk +0 lines, -73 lines 0 comments Download
D ash/system/status_area_widget_delegate.cc View 1 chunk +0 lines, -231 lines 0 comments Download
M ash/wm/gestures/shelf_gesture_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
James Cook
msw, please take a look.
4 years, 5 months ago (2016-06-29 18:01:40 UTC) #2
msw
nice; lgtm
4 years, 5 months ago (2016-06-29 18:27:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109193002/20001
4 years, 5 months ago (2016-06-29 19:20:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 21:40:29 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 21:43:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba93d044cec883e554ec76c7d463d3ba915eab26
Cr-Commit-Position: refs/heads/master@{#402941}

Powered by Google App Engine
This is Rietveld 408576698