third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp - Issue 2226863003: [DevTools] Reduce API surface of String16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

Issue 2226863003: [DevTools] Reduce API surface of String16. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wrong vector usage Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

index 814b7f91ea52c4fcb1e6c4a24fb404b888764049..fe800723dcb39cbf2ba0c45bc990f25da89d0bb4 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

@@ -24,11 +24,11 @@ namespace blink {

// static

bool V8InspectorSession::canDispatchMethod(const String16& method)

{

- return method.startWith(protocol::Runtime::Metainfo::commandPrefix)

- || method.startWith(protocol::Debugger::Metainfo::commandPrefix)

- || method.startWith(protocol::Profiler::Metainfo::commandPrefix)

- || method.startWith(protocol::HeapProfiler::Metainfo::commandPrefix)

- || method.startWith(protocol::Console::Metainfo::commandPrefix);

+ return method.startsWith(protocol::Runtime::Metainfo::commandPrefix)

+ || method.startsWith(protocol::Debugger::Metainfo::commandPrefix)

+ || method.startsWith(protocol::Profiler::Metainfo::commandPrefix)

+ || method.startsWith(protocol::HeapProfiler::Metainfo::commandPrefix)

+ || method.startsWith(protocol::Console::Metainfo::commandPrefix);

}

std::unique_ptr<V8InspectorSessionImpl> V8InspectorSessionImpl::create(V8InspectorImpl* inspector, int contextGroupId, protocol::FrontendChannel* channel, const String16* state)