Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

Issue 2226863003: [DevTools] Reduce API surface of String16. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: wrong vector usage Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/v8_inspector/V8InspectorSessionImpl.h" 5 #include "platform/v8_inspector/V8InspectorSessionImpl.h"
6 6
7 #include "platform/inspector_protocol/Parser.h" 7 #include "platform/inspector_protocol/Parser.h"
8 #include "platform/v8_inspector/InjectedScript.h" 8 #include "platform/v8_inspector/InjectedScript.h"
9 #include "platform/v8_inspector/InspectedContext.h" 9 #include "platform/v8_inspector/InspectedContext.h"
10 #include "platform/v8_inspector/RemoteObjectId.h" 10 #include "platform/v8_inspector/RemoteObjectId.h"
11 #include "platform/v8_inspector/V8ConsoleAgentImpl.h" 11 #include "platform/v8_inspector/V8ConsoleAgentImpl.h"
12 #include "platform/v8_inspector/V8Debugger.h" 12 #include "platform/v8_inspector/V8Debugger.h"
13 #include "platform/v8_inspector/V8DebuggerAgentImpl.h" 13 #include "platform/v8_inspector/V8DebuggerAgentImpl.h"
14 #include "platform/v8_inspector/V8HeapProfilerAgentImpl.h" 14 #include "platform/v8_inspector/V8HeapProfilerAgentImpl.h"
15 #include "platform/v8_inspector/V8InspectorImpl.h" 15 #include "platform/v8_inspector/V8InspectorImpl.h"
16 #include "platform/v8_inspector/V8ProfilerAgentImpl.h" 16 #include "platform/v8_inspector/V8ProfilerAgentImpl.h"
17 #include "platform/v8_inspector/V8RuntimeAgentImpl.h" 17 #include "platform/v8_inspector/V8RuntimeAgentImpl.h"
18 #include "platform/v8_inspector/V8StringUtil.h" 18 #include "platform/v8_inspector/V8StringUtil.h"
19 #include "platform/v8_inspector/public/V8ContextInfo.h" 19 #include "platform/v8_inspector/public/V8ContextInfo.h"
20 #include "platform/v8_inspector/public/V8InspectorClient.h" 20 #include "platform/v8_inspector/public/V8InspectorClient.h"
21 21
22 namespace blink { 22 namespace blink {
23 23
24 // static 24 // static
25 bool V8InspectorSession::canDispatchMethod(const String16& method) 25 bool V8InspectorSession::canDispatchMethod(const String16& method)
26 { 26 {
27 return method.startWith(protocol::Runtime::Metainfo::commandPrefix) 27 return method.startsWith(protocol::Runtime::Metainfo::commandPrefix)
28 || method.startWith(protocol::Debugger::Metainfo::commandPrefix) 28 || method.startsWith(protocol::Debugger::Metainfo::commandPrefix)
29 || method.startWith(protocol::Profiler::Metainfo::commandPrefix) 29 || method.startsWith(protocol::Profiler::Metainfo::commandPrefix)
30 || method.startWith(protocol::HeapProfiler::Metainfo::commandPrefix) 30 || method.startsWith(protocol::HeapProfiler::Metainfo::commandPrefix)
31 || method.startWith(protocol::Console::Metainfo::commandPrefix); 31 || method.startsWith(protocol::Console::Metainfo::commandPrefix);
32 } 32 }
33 33
34 std::unique_ptr<V8InspectorSessionImpl> V8InspectorSessionImpl::create(V8Inspect orImpl* inspector, int contextGroupId, protocol::FrontendChannel* channel, const String16* state) 34 std::unique_ptr<V8InspectorSessionImpl> V8InspectorSessionImpl::create(V8Inspect orImpl* inspector, int contextGroupId, protocol::FrontendChannel* channel, const String16* state)
35 { 35 {
36 return wrapUnique(new V8InspectorSessionImpl(inspector, contextGroupId, chan nel, state)); 36 return wrapUnique(new V8InspectorSessionImpl(inspector, contextGroupId, chan nel, state));
37 } 37 }
38 38
39 V8InspectorSessionImpl::V8InspectorSessionImpl(V8InspectorImpl* inspector, int c ontextGroupId, protocol::FrontendChannel* channel, const String16* savedState) 39 V8InspectorSessionImpl::V8InspectorSessionImpl(V8InspectorImpl* inspector, int c ontextGroupId, protocol::FrontendChannel* channel, const String16* savedState)
40 : m_contextGroupId(contextGroupId) 40 : m_contextGroupId(contextGroupId)
41 , m_inspector(inspector) 41 , m_inspector(inspector)
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 std::unique_ptr<protocol::Array<protocol::Debugger::API::SearchMatch>> V8Inspect orSessionImpl::searchInTextByLines(const String16& text, const String16& query, bool caseSensitive, bool isRegex) 313 std::unique_ptr<protocol::Array<protocol::Debugger::API::SearchMatch>> V8Inspect orSessionImpl::searchInTextByLines(const String16& text, const String16& query, bool caseSensitive, bool isRegex)
314 { 314 {
315 std::vector<std::unique_ptr<protocol::Debugger::SearchMatch>> matches = sear chInTextByLinesImpl(this, text, query, caseSensitive, isRegex); 315 std::vector<std::unique_ptr<protocol::Debugger::SearchMatch>> matches = sear chInTextByLinesImpl(this, text, query, caseSensitive, isRegex);
316 std::unique_ptr<protocol::Array<protocol::Debugger::API::SearchMatch>> resul t = protocol::Array<protocol::Debugger::API::SearchMatch>::create(); 316 std::unique_ptr<protocol::Array<protocol::Debugger::API::SearchMatch>> resul t = protocol::Array<protocol::Debugger::API::SearchMatch>::create();
317 for (size_t i = 0; i < matches.size(); ++i) 317 for (size_t i = 0; i < matches.size(); ++i)
318 result->addItem(std::move(matches[i])); 318 result->addItem(std::move(matches[i]));
319 return result; 319 return result;
320 } 320 }
321 321
322 } // namespace blink 322 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698