third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp - Issue 2226863003: [DevTools] Reduce API surface of String16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 2226863003: [DevTools] Reduce API surface of String16. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/inspector_protocol/String16STL.h ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

index cf2c2ba82e78c37f908e18bc1283ad9a97fd7e2d..a7f787432329e695ed9da019f12a7476403eadac 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

@@ -516,7 +516,7 @@ void V8RuntimeAgentImpl::compileScript(ErrorString* errorString,

if (!persistScript)

return;

- String16 scriptValueId = String16::fromInteger(script->GetUnboundScript()->GetId());

+ String16 scriptValueId = protocol::string16FromInteger(script->GetUnboundScript()->GetId());

std::unique_ptr<v8::Global<v8::Script>> global(new v8::Global<v8::Script>(m_inspector->isolate(), script));

m_compiledScripts[scriptValueId] = std::move(global);

*scriptId = scriptValueId;