third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp - Issue 2226863003: [DevTools] Reduce API surface of String16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

Issue 2226863003: [DevTools] Reduce API surface of String16. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/inspector_protocol/String16STL.h ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

index 57712a9c107439879c99a6ba3c8e568b08a92d4e..0f99b619d92e5011da562e3bb73600e8dbe59238 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

@@ -61,7 +61,7 @@ std::unique_ptr<protocol::Profiler::CPUProfileNode> buildInspectorObjectFor(v8::

std::unique_ptr<protocol::Runtime::CallFrame> callFrame = protocol::Runtime::CallFrame::create()

.setFunctionName(toProtocolString(node->GetFunctionName()))

- .setScriptId(String16::fromInteger(node->GetScriptId()))

+ .setScriptId(protocol::string16FromInteger(node->GetScriptId()))

.setUrl(toProtocolString(node->GetScriptResourceName()))

.setLineNumber(node->GetLineNumber() - 1)

.setColumnNumber(node->GetColumnNumber() - 1)

@@ -281,7 +281,7 @@ void V8ProfilerAgentImpl::stop(ErrorString* errorString, std::unique_ptr<protoco

String16 V8ProfilerAgentImpl::nextProfileId()

{

- return String16::fromInteger(atomicIncrement(&s_lastProfileId));

+ return protocol::string16FromInteger(atomicIncrement(&s_lastProfileId));

}

void V8ProfilerAgentImpl::startProfiling(const String16& title)