third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp - Issue 2226863003: [DevTools] Reduce API surface of String16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

Issue 2226863003: [DevTools] Reduce API surface of String16. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

index 3b4552ee8d9147e986bdf8702d8373240d750e02..844e015bfabe01336d35a89444feef38328ebe3c 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

@@ -307,7 +307,7 @@ std::unique_ptr<protocol::Runtime::ExceptionDetails> InjectedScript::createExcep

{

std::unique_ptr<protocol::Runtime::ExceptionDetails> exceptionDetailsObject = protocol::Runtime::ExceptionDetails::create()

.setText(toProtocolString(message->Get()))

- .setScriptId(String16::fromInteger(message->GetScriptOrigin().ScriptID()->Value()))

+ .setScriptId(protocol::string16FromInteger(message->GetScriptOrigin().ScriptID()->Value()))

.setLineNumber(message->GetLineNumber(m_context->context()).FromMaybe(1) - 1)

.setColumnNumber(message->GetStartColumn(m_context->context()).FromMaybe(0))

.build();