Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Values.cpp

Issue 2226863003: [DevTools] Reduce API surface of String16. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/inspector_protocol/Values.cpp
diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Values.cpp b/third_party/WebKit/Source/platform/inspector_protocol/Values.cpp
index 5b8f13b4930e2716f71136b7ece01bc11f351181..61c8be4c4817274f9ea27421779d059382afa9a3 100644
--- a/third_party/WebKit/Source/platform/inspector_protocol/Values.cpp
+++ b/third_party/WebKit/Source/platform/inspector_protocol/Values.cpp
@@ -35,13 +35,14 @@ inline bool escapeChar(UChar c, String16Builder* dst)
return true;
}
-const LChar hexDigits[17] = "0123456789ABCDEF";
+const char hexDigits[17] = "0123456789ABCDEF";
void appendUnsignedAsHex(UChar number, String16Builder* dst)
{
dst->append("\\u");
for (size_t i = 0; i < 4; ++i) {
- dst->append(hexDigits[(number & 0xF000) >> 12]);
+ UChar c = hexDigits[(number & 0xF000) >> 12];
+ dst->append(c);
number <<= 4;
}
}
@@ -158,9 +159,9 @@ void FundamentalValue::writeJSON(String16Builder* output) const
output->append(nullString, 4);
return;
}
- output->append(String16::fromDouble(m_doubleValue));
+ output->append(protocol::string16FromDouble(m_doubleValue));
} else if (type() == TypeInteger) {
- output->append(String16::fromInteger(m_integerValue));
+ output->append(protocol::string16FromInteger(m_integerValue));
}
}

Powered by Google App Engine
This is Rietveld 408576698