scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py - Issue 2226753003: Remove the android_isolate_path option from LocalGTestTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py

Issue 2226753003: Remove the android_isolate_path option from LocalGTestTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: thakis/sergiyb comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py b/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py

index 7a44b0eacc6c2ea1b8d1fc2a0f861857eb8f9eaf..9ecddfbc96e045a53320acb4c2e6839d9d8842c6 100644

--- a/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py

+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py

@@ -1603,10 +1603,7 @@ SPEC = {

steps.generate_junit_test,

'tests': [

- steps.GTestTest(

- 'components_browsertests',

- android_isolate_path='components/components_browsertests.isolate',

- android_tool='asan'),

+ steps.GTestTest('components_browsertests', android_tool='asan'),

steps.GTestTest('gfx_unittests', android_tool='asan'),

Dirk Pranke 2016/08/09 23:52:16 why are these even still listed here, rather than

jbudorick 2016/08/09 23:55:28 AFAICT yes, because the gtest generator doesn't ta

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md » ('j') | no next file with comments »