Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md

Issue 2226753003: Remove the android_isolate_path option from LocalGTestTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: thakis/sergiyb comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md
diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md b/scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md
index e79edc03b9fdde279450d066233e6df95cf6dd8f..4e794380a5ab959e38ef8877e1819d4e9cbab936 100644
--- a/scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md
+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md
@@ -163,25 +163,7 @@ they take effect and build still passes.
### Add a new non gtest-based test
Generally, look at [steps.py](https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipe_modules/chromium_tests/steps.py)
-, and either use an existing class there, or add a new one. For example, look at
-the Android Tests (amp split) [recipe](https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py)
-, which uses a special step to talk to an external service:
-
-```
-'Android Tests (amp split)': {
- ...
- 'tests': [
- steps.AndroidInstrumentationTest('AndroidWebViewTest'),
- steps.AndroidInstrumentationTest('ContentShellTest'),
- steps.AMPGTestTest('android_webview_unittests',
- device_name=['Nexus 5'], device_os=['4.4.2']),
- steps.AMPGTestTest('base_unittests',
- device_name=['Nexus 5'], device_os=['4.4.2'],
- android_isolate_path='base/base_unittests.isolate'),
- ...
- ]
-}
-```
+, and either use an existing class there, or add a new one.
## Background
Chromium tests are currently run on buildbot, and are organized by builders.

Powered by Google App Engine
This is Rietveld 408576698