Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2226663003: window.visualViewport.clientWidth|Height shouldn't assume scaled scrollbar (Closed)

Created:
4 years, 4 months ago by ymalik
Modified:
4 years, 4 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

window.visualViewport.clientWidth|Height shouldn't assume scaled scrollbar BUG=634424 Committed: https://crrev.com/78db10b48f946769c18992bf80c7b344da671c75 Cr-Commit-Position: refs/heads/master@{#410386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-custom-scrollbars.html View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ymalik
4 years, 4 months ago (2016-08-08 15:15:57 UTC) #3
bokan
lgtm, thanks.
4 years, 4 months ago (2016-08-08 15:53:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226663003/1
4 years, 4 months ago (2016-08-08 16:01:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 17:14:55 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 17:16:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78db10b48f946769c18992bf80c7b344da671c75
Cr-Commit-Position: refs/heads/master@{#410386}

Powered by Google App Engine
This is Rietveld 408576698