Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html

Issue 2226663003: window.visualViewport.clientWidth|Height shouldn't assume scaled scrollbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html b/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html
index 6928a71aaf4c7b378b355b5bf6c5a2e9194891f1..a4e4dadb633df1488779b04e0b8aee7491dad964 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html
@@ -10,8 +10,8 @@
<script>
var browserZoomFactor = 1.25;
var pageScaleFactor = 2;
- var scrollbarWidth = 15;
- var scrollbarHeight = 15;
+ var scrollbarWidthCSSPixels = 15 / pageScaleFactor;
+ var scrollbarHeightCSSPixels = 15 / pageScaleFactor;
function viewport() {
return window.visualViewport;
@@ -24,15 +24,15 @@
internals.setPageScaleFactor(pageScaleFactor);
// Verify viewport dimensions exclude scrollbar.
- assert_equals(viewport().clientWidth, 800 / pageScaleFactor - scrollbarWidth);
- assert_equals(viewport().clientHeight, 600 / pageScaleFactor - scrollbarHeight);
+ assert_equals(viewport().clientWidth, 800 / pageScaleFactor - scrollbarWidthCSSPixels);
+ assert_equals(viewport().clientHeight, 600 / pageScaleFactor - scrollbarHeightCSSPixels);
// Apply browser zoom.
window.internals.setZoomFactor(browserZoomFactor);
// Verify scrollbar exclusion with browser zoom.
- assert_equals(viewport().clientWidth, 800 / pageScaleFactor / browserZoomFactor - scrollbarWidth);
- assert_equals(viewport().clientHeight, 600 / pageScaleFactor / browserZoomFactor - scrollbarHeight);
+ assert_equals(viewport().clientWidth, 800 / pageScaleFactor / browserZoomFactor - scrollbarWidthCSSPixels);
+ assert_equals(viewport().clientHeight, 600 / pageScaleFactor / browserZoomFactor - scrollbarHeightCSSPixels);
t.done();
});
}, 'Verify viewport dimensions exclude scrollbars.');

Powered by Google App Engine
This is Rietveld 408576698