Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2226623002: Remove some obsolete entries in Web Animations IDL (Closed)

Created:
4 years, 4 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 4 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some obsolete entries in Web Animations IDL The following fields in the animations IDL files are no longer in the specced interface: - AnimationTimeline - playbackRate, play() - AnimationEffectTiming - playbackRate BUG=624639 Committed: https://crrev.com/24c7b556a80897aa0ca8ec74b0f720ed60f020a8 Cr-Commit-Position: refs/heads/master@{#410545}

Patch Set 1 #

Patch Set 2 : Update global-interface-listing-expected #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M third_party/WebKit/LayoutTests/web-animations-api/effect-of-keyframeeffect-on-getComputedTiming.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationEffectTiming.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimeline.idl View 1 chunk +2 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
suzyh_UTC10 (ex-contributor)
4 years, 4 months ago (2016-08-08 06:51:54 UTC) #2
alancutter (OOO until 2018)
lgtm
4 years, 4 months ago (2016-08-08 07:03:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226623002/1
4 years, 4 months ago (2016-08-08 07:09:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/275682)
4 years, 4 months ago (2016-08-08 07:57:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226623002/20001
4 years, 4 months ago (2016-08-08 22:51:39 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 02:39:57 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 02:42:36 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24c7b556a80897aa0ca8ec74b0f720ed60f020a8
Cr-Commit-Position: refs/heads/master@{#410545}

Powered by Google App Engine
This is Rietveld 408576698