Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2226363003: Use StringView for String::reverseFind. (Closed)

Created:
4 years, 4 months ago by esprehn
Modified:
4 years, 4 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use StringView for String::reverseFind. This avoids the allocations for any callers passing literal strings. I also made AtomicString and String's API match. BUG=615174 Committed: https://crrev.com/8d2cf7c3e866ff9ec49a8b5d544dde87f10716c4 Cr-Commit-Position: refs/heads/master@{#410930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M third_party/WebKit/Source/wtf/text/AtomicString.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 4 chunks +13 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
esprehn
4 years, 4 months ago (2016-08-10 00:45:18 UTC) #6
haraken
LGTM
4 years, 4 months ago (2016-08-10 00:55:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226363003/1
4 years, 4 months ago (2016-08-10 01:02:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 02:44:08 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 02:47:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d2cf7c3e866ff9ec49a8b5d544dde87f10716c4
Cr-Commit-Position: refs/heads/master@{#410930}

Powered by Google App Engine
This is Rietveld 408576698