third_party/WebKit/Source/wtf/text/StringImpl.h - Issue 2226363003: Use StringView for String::reverseFind.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringImpl.h

Issue 2226363003: Use StringView for String::reverseFind. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringImpl.h

diff --git a/third_party/WebKit/Source/wtf/text/StringImpl.h b/third_party/WebKit/Source/wtf/text/StringImpl.h

index 1311c0d9f20c317405474afb04a41d9a569ef716..30736e2e2fc1bcd33c5d600d5b75d61e7ebffb5a 100644

--- a/third_party/WebKit/Source/wtf/text/StringImpl.h

+++ b/third_party/WebKit/Source/wtf/text/StringImpl.h

@@ -378,7 +378,7 @@ public:

size_t findIgnoringASCIICase(const StringView&, unsigned index = 0);

size_t reverseFind(UChar, unsigned index = UINT_MAX);

- size_t reverseFind(StringImpl*, unsigned index = UINT_MAX);

+ size_t reverseFind(const StringView&, unsigned index = UINT_MAX);

bool startsWith(UChar) const;

bool startsWith(const StringView&) const;

@@ -716,5 +716,6 @@ using WTF::TextCaseSensitivity;

using WTF::equal;

using WTF::equalNonNull;

using WTF::lengthOfNullTerminatedString;

+using WTF::reverseFind;

#endif