Track subresources with cert errors separately from mixed content

Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations. (This CL does not actually make aforementioned
UI changes, but rather just sets up the plumbing to do so.)

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  Teach SecurityStateModel about subresources with cert errors
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  (this CL)

BUG=634171, 636986
Committed: https://crrev.com/cd2e30cd6679e2249af296807d7270087879919d
Cr-Commit-Position: refs/heads/master@{#411564}

[estark, 2016-08-09 18:17:14]

Description was changed from

==========
Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations.

BUG=634171
==========

to

==========
Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations. (This CL does not actually make aforementioned
UI changes, but rather just sets up the plumbing to do so.)

BUG=634171
==========

[estark, 2016-08-09 18:17:47]

Description was changed from

==========
Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations. (This CL does not actually make aforementioned
UI changes, but rather just sets up the plumbing to do so.)

BUG=634171
==========

to

==========
Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations. (This CL does not actually make aforementioned
UI changes, but rather just sets up the plumbing to do so.)

This is based on top of https://codereview.chromium.org/2225213004/

BUG=634171
==========

[estark, 2016-08-09 18:21:32]

Description was changed from

==========
Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations. (This CL does not actually make aforementioned
UI changes, but rather just sets up the plumbing to do so.)

This is based on top of https://codereview.chromium.org/2225213004/

BUG=634171
==========

to

==========
Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations. (This CL does not actually make aforementioned
UI changes, but rather just sets up the plumbing to do so.)

#1: https://codereview.chromium.org/2224193003/
 Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
 Teach SecurityStateModel about subresources with cert errors
#3: https://codereview.chromium.org/2225213004/
 Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  (this CL)

BUG=634171
==========

[estark, 2016-08-09 18:22:42]

Description was changed from

==========
Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations. (This CL does not actually make aforementioned
UI changes, but rather just sets up the plumbing to do so.)

#1: https://codereview.chromium.org/2224193003/
 Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
 Teach SecurityStateModel about subresources with cert errors
#3: https://codereview.chromium.org/2225213004/
 Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  (this CL)

BUG=634171
==========

to

==========
Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations. (This CL does not actually make aforementioned
UI changes, but rather just sets up the plumbing to do so.)

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  Teach SecurityStateModel about subresources with cert errors
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  (this CL)

BUG=634171
==========

[estark, 2016-08-11 16:03:06]

Description was changed from

==========
Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations. (This CL does not actually make aforementioned
UI changes, but rather just sets up the plumbing to do so.)

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  Teach SecurityStateModel about subresources with cert errors
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  (this CL)

BUG=634171
==========

to

==========
Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations. (This CL does not actually make aforementioned
UI changes, but rather just sets up the plumbing to do so.)

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  Teach SecurityStateModel about subresources with cert errors
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  (this CL)

BUG=634171,636986
==========

[estark, 2016-08-11 16:06:28]

estark@chromium.org changed reviewers:
+ jam@chromium.org

[estark, 2016-08-11 16:06:28]

jam, this is #4/4. Thanks!

[jam, 2016-08-11 19:53:20]

lgtm

https://codereview.chromium.org/2226363002/diff/1/chrome/browser/ssl/ssl_brow...
File chrome/browser/ssl/ssl_browser_tests.cc (right):

https://codereview.chromium.org/2226363002/diff/1/chrome/browser/ssl/ssl_brow...
chrome/browser/ssl/ssl_browser_tests.cc:341: // interceptor to hang all favicon
requests.
nit: did you mean to have nearly the same comment here and above? I would just
take out the first one and leave this one

https://codereview.chromium.org/2226363002/diff/1/content/public/browser/web_...
File content/public/browser/web_contents.h (right):

https://codereview.chromium.org/2226363002/diff/1/content/public/browser/web_...
content/public/browser/web_contents.h:372: virtual bool
DisplayedContentWithCertErrors() const = 0;
this method and the one above are only called from within content/. So you can
just put them on WebContentsImpl only and not on the public interface
(https://www.chromium.org/developers/content-module/content-api)

[estark, 2016-08-12 04:56:02]

https://codereview.chromium.org/2226363002/diff/1/chrome/browser/ssl/ssl_brow...
File chrome/browser/ssl/ssl_browser_tests.cc (right):

https://codereview.chromium.org/2226363002/diff/1/chrome/browser/ssl/ssl_brow...
chrome/browser/ssl/ssl_browser_tests.cc:341: // interceptor to hang all favicon
requests.
On 2016/08/11 19:53:20, jam wrote:
> nit: did you mean to have nearly the same comment here and above? I would just
> take out the first one and leave this one

Done.

https://codereview.chromium.org/2226363002/diff/1/content/public/browser/web_...
File content/public/browser/web_contents.h (right):

https://codereview.chromium.org/2226363002/diff/1/content/public/browser/web_...
content/public/browser/web_contents.h:372: virtual bool
DisplayedContentWithCertErrors() const = 0;
On 2016/08/11 19:53:20, jam wrote:
> this method and the one above are only called from within content/. So you can
> just put them on WebContentsImpl only and not on the public interface
> (https://www.chromium.org/developers/content-module/content-api)

Done.

[estark, 2016-08-12 04:56:29]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 04:56:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 06:30:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 06:30:59]

Dry run: This issue passed the CQ dry run.

[estark, 2016-08-12 06:47:32]

The CQ bit was checked by estark@chromium.org

[estark, 2016-08-12 06:47:33]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2226363002/#ps80001
(title: "add comments")

[commit-bot: I haz the power, 2016-08-12 06:47:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 06:51:33]

Description was changed from

==========
Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations. (This CL does not actually make aforementioned
UI changes, but rather just sets up the plumbing to do so.)

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  Teach SecurityStateModel about subresources with cert errors
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  (this CL)

BUG=634171,636986
==========

to

==========
Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations. (This CL does not actually make aforementioned
UI changes, but rather just sets up the plumbing to do so.)

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  Teach SecurityStateModel about subresources with cert errors
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  (this CL)

BUG=634171,636986
==========

[commit-bot: I haz the power, 2016-08-12 06:51:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-12 06:53:22]

Description was changed from

==========
Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations. (This CL does not actually make aforementioned
UI changes, but rather just sets up the plumbing to do so.)

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  Teach SecurityStateModel about subresources with cert errors
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  (this CL)

BUG=634171,636986
==========

to

==========
Track subresources with cert errors separately from mixed content

This is the final in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

Previously, when WebContentsImpl learned about a subresource with
certificate errors, it set its own DisplayedInsecureContent() flag for a
passive resource, or notified SSLManager::HostRanInsecureContent() about
an active subresource. This is the same set of mechanisms that was used
for subresources loaded over HTTP on HTTPS pages (mixed content).

In this CL, SSLManager, SSLPolicy, and SSLPolicyBackend get mechanisms
for tracking subresources with cert errors separately from mixed
content. WebContentsImpl also gets a DisplayedContentWithCertErrors()
flag separate from DisplayedInsecureContent() which it uses for mixed
content.

This separate set of plumbing allows browser UI to distinguish mixed
content from subresources with cert errors; for example, the DevTools
security panel should use a separate message to describe these two
different situations. (This CL does not actually make aforementioned
UI changes, but rather just sets up the plumbing to do so.)

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  Teach SecurityStateModel about subresources with cert errors
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  (this CL)

BUG=634171,636986

Committed: https://crrev.com/cd2e30cd6679e2249af296807d7270087879919d
Cr-Commit-Position: refs/heads/master@{#411564}
==========

[commit-bot: I haz the power, 2016-08-12 06:53:22]

Patchset 5 (id:??) landed as
https://crrev.com/cd2e30cd6679e2249af296807d7270087879919d
Cr-Commit-Position: refs/heads/master@{#411564}