Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2226363002: Track subresources with cert errors separately from mixed content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/ssl/ssl_policy_backend.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 1cc351ebb04ccfbe3878f367a316f36a1e51eedd..a29d32926b90528977a01ed62a8e206b56d852af 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -291,7 +291,6 @@ class CONTENT_EXPORT WebContentsImpl
uint64_t GetUploadSize() const override;
uint64_t GetUploadPosition() const override;
const std::string& GetEncoding() const override;
- bool DisplayedInsecureContent() const override;
void IncrementCapturerCount(const gfx::Size& capture_size) override;
void DecrementCapturerCount() override;
int GetCapturerCount() const override;
@@ -408,6 +407,14 @@ class CONTENT_EXPORT WebContentsImpl
bool GetAllowOtherViews() override;
#endif
+ // Returns true if this is a secure page which has displayed content
+ // loaded over insecure HTTP.
+ bool DisplayedInsecureContent() const;
+
+ // Returns true if this page has displayed content loaded over HTTPS
+ // with certificate errors.
+ bool DisplayedContentWithCertErrors() const;
+
// Implementation of PageNavigator.
WebContents* OpenURL(const OpenURLParams& params) override;
@@ -1201,9 +1208,14 @@ class CONTENT_EXPORT WebContentsImpl
// The canonicalized character encoding.
std::string canonical_encoding_;
- // True if this is a secure page which displayed insecure content.
+ // True if this is a secure page which displayed mixed content (loaded
+ // over HTTP).
bool displayed_insecure_content_;
+ // True if this page displayed subresources loaded with HTTPS
+ // certificate errors.
+ bool displayed_content_with_cert_errors_;
+
// Whether the initial empty page has been accessed by another page, making it
// unsafe to show the pending URL. Usually false unless another window tries
// to modify the blank page. Always false after the first commit.
« no previous file with comments | « content/browser/ssl/ssl_policy_backend.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698