Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2226323003: Fix Alt-Svc and proxy interaction. (Closed)

Created:
4 years, 4 months ago by Bence
Modified:
4 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Alt-Svc and proxy interaction. See also https://github.com/httpwg/http-extensions/issues/62. BUG=392575 Committed: https://crrev.com/2e884788b0536bb37f2bd38712aa4fca98db6be6 Cr-Commit-Position: refs/heads/master@{#411405}

Patch Set 1 #

Patch Set 2 : Re: #7. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase on https://crrev.com/2219133002. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -21 lines) Patch
M net/http/http_network_transaction_unittest.cc View 1 2 3 1 chunk +92 lines, -0 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 2 3 1 chunk +1 line, -21 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 4 months ago (2016-08-09 23:30:38 UTC) #6
Ryan Hamilton
lgtm. any possibility that adding a test is easy? I'm guessing not.
4 years, 4 months ago (2016-08-10 00:50:22 UTC) #7
Bence
On 2016/08/10 00:50:22, Ryan Hamilton wrote: > lgtm. any possibility that adding a test is ...
4 years, 4 months ago (2016-08-11 14:37:09 UTC) #10
Ryan Hamilton
lgtm thanks for adding the test!
4 years, 4 months ago (2016-08-11 18:37:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226323003/60001
4 years, 4 months ago (2016-08-11 19:41:26 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-11 19:45:42 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 19:48:36 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2e884788b0536bb37f2bd38712aa4fca98db6be6
Cr-Commit-Position: refs/heads/master@{#411405}

Powered by Google App Engine
This is Rietveld 408576698