Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: net/http/http_stream_factory_impl_job.cc

Issue 2226323003: Fix Alt-Svc and proxy interaction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase on https://crrev.com/2219133002. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_transaction_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_job.cc
diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc
index 415faca247130e20491abdb97c5740d8827d04fe..3f7c04b77b14372f81357dc871b3879cd0b08a34 100644
--- a/net/http/http_stream_factory_impl_job.cc
+++ b/net/http/http_stream_factory_impl_job.cc
@@ -705,28 +705,8 @@ int HttpStreamFactoryImpl::Job::DoResolveProxy() {
return OK;
}
- // TODO(rch): remove this code since Alt-Svc seems to prohibit it.
- GURL url_for_proxy = origin_url_;
- // For SPDY via Alt-Svc, set |alternative_service_url_| to
- // https://<alternative host>:<alternative port>/...
- // so the proxy resolution works with the actual destination, and so
- // that the correct socket pool is used.
- if (IsSpdyAlternative()) {
- // TODO(rch): Figure out how to make QUIC iteract with PAC
- // scripts. By not re-writing the URL, we will query the PAC script
- // for the proxy to use to reach the original URL via TCP. But
- // the alternate request will be going via UDP to a different port.
- GURL::Replacements replacements;
- // new_port needs to be in scope here because GURL::Replacements references
- // the memory contained by it directly.
- const std::string new_port = base::UintToString(alternative_service_.port);
- replacements.SetSchemeStr("https");
- replacements.SetPortStr(new_port);
- url_for_proxy = url_for_proxy.ReplaceComponents(replacements);
- }
-
return session_->proxy_service()->ResolveProxy(
- url_for_proxy, request_info_.method, &proxy_info_, io_callback_,
+ origin_url_, request_info_.method, &proxy_info_, io_callback_,
&pac_request_, session_->params().proxy_delegate, net_log_);
}
« no previous file with comments | « net/http/http_network_transaction_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698