Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2226313003: Settings Router Refactor: Remove one last stray subpage-back. (Closed)

Created:
4 years, 4 months ago by tommycli
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings Router Refactor: Remove one last stray subpage-back. BUG=632382 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3ee2a94b5980556a55e93be8926a496c680cdd5c Cr-Commit-Position: refs/heads/master@{#410872}

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M chrome/browser/resources/settings/settings_page/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_subpage.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_subpage.js View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 1 2 1 chunk +34 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (15 generated)
tommycli
dbeam: PTAL before someone notices it's broken thx ;)
4 years, 4 months ago (2016-08-09 19:17:02 UTC) #5
Dan Beam
lgtm but can haz test or something?
4 years, 4 months ago (2016-08-09 19:18:46 UTC) #6
tommycli
On 2016/08/09 19:18:46, Dan Beam wrote: > lgtm but can haz test or something? Hi, ...
4 years, 4 months ago (2016-08-09 20:24:06 UTC) #14
Dan Beam
lgtm
4 years, 4 months ago (2016-08-09 23:34:53 UTC) #17
tommycli
On 2016/08/09 23:34:53, Dan Beam wrote: > lgtm thank you sir! submitting
4 years, 4 months ago (2016-08-09 23:35:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226313003/40001
4 years, 4 months ago (2016-08-09 23:36:26 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-09 23:42:28 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 23:45:50 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3ee2a94b5980556a55e93be8926a496c680cdd5c
Cr-Commit-Position: refs/heads/master@{#410872}

Powered by Google App Engine
This is Rietveld 408576698