chrome/browser/resources/settings/settings_page/settings_subpage.js - Issue 2226313003: Settings Router Refactor: Remove one last stray subpage-back.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_subpage.js

Issue 2226313003: Settings Router Refactor: Remove one last stray subpage-back. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_page/settings_subpage.html ('k') | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_subpage.js

diff --git a/chrome/browser/resources/settings/settings_page/settings_subpage.js b/chrome/browser/resources/settings/settings_page/settings_subpage.js

index abb43dc1421e2afd514d7675d6f5a6b20a606c36..eaa4874cc6186bbd8346c75c05b5d40ba30e0ce2 100644

--- a/chrome/browser/resources/settings/settings_page/settings_subpage.js

+++ b/chrome/browser/resources/settings/settings_page/settings_subpage.js

@@ -5,8 +5,7 @@

/**

* @fileoverview

* 'settings-subpage' shows a subpage beneath a subheader. The header contains

- * the subpage title and a back icon. The back icon fires an event which

- * is caught by settings-animated-pages, so it requires no separate handling.

+ * the subpage title and a back icon.

Polymer({

@@ -44,8 +43,7 @@ Polymer({

/** @private */

onTapBack_: function() {

- // Event is caught by settings-animated-pages.

- this.fire('subpage-back');

+ settings.navigateTo(assert(settings.getCurrentRoute().parent));

/** @private */