Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 2226293002: [turbolizer] Visualize also the dead nodes. (Closed)

Created:
4 years, 4 months ago by bgeron
Modified:
4 years, 4 months ago
Reviewers:
*Jarin, danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@t-p2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbolizer] Visualize also the dead nodes. R=danno,jarin BUG= Committed: https://crrev.com/01766cd8ccff64bc431299a48f757c989a6e962d Cr-Commit-Position: refs/heads/master@{#38502}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -36 lines) Patch
M src/compiler/all-nodes.h View 1 chunk +13 lines, -5 lines 0 comments Download
M src/compiler/all-nodes.cc View 1 chunk +23 lines, -15 lines 0 comments Download
M src/compiler/escape-analysis-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-replay.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 4 chunks +10 lines, -4 lines 0 comments Download
M src/compiler/osr.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/store-store-elimination.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-osr.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/turbolizer/graph-view.js View 3 chunks +8 lines, -0 lines 0 comments Download
M tools/turbolizer/index.html View 1 chunk +2 lines, -0 lines 0 comments Download
A tools/turbolizer/live.png View Binary file 0 comments Download
M tools/turbolizer/node.js View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/turbolizer/turbo-visualizer.css View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
bgeron
Please take a look. The heart icon comes from the same icon set that you ...
4 years, 4 months ago (2016-08-09 13:54:12 UTC) #1
danno
turbolizer stuff lgtm
4 years, 4 months ago (2016-08-09 13:56:41 UTC) #3
Jarin
**/compiler/* lgtm
4 years, 4 months ago (2016-08-09 14:02:26 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2225683009 Patch 1). Please resolve the dependency and ...
4 years, 4 months ago (2016-08-09 15:20:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226293002/1
4 years, 4 months ago (2016-08-09 15:57:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 16:20:23 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 16:20:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01766cd8ccff64bc431299a48f757c989a6e962d
Cr-Commit-Position: refs/heads/master@{#38502}

Powered by Google App Engine
This is Rietveld 408576698