Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2225683009: [turbolizer] Show operator properties and arity in tooltip. (Closed)

Created:
4 years, 4 months ago by bgeron
Modified:
4 years, 4 months ago
Reviewers:
Jarin, danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@t-base
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbolizer] Show operator properties and arity in tooltip. BUG= Committed: https://crrev.com/a57b243c0fa4d66726d30f796999610e8fb1d33a Cr-Commit-Position: refs/heads/master@{#38500}

Patch Set 1 #

Total comments: 2

Patch Set 2 : OP_PROP_LIST -> OPERATOR_PROPERTY_LIST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M src/compiler/graph-visualizer.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M src/compiler/operator.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/operator.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M tools/turbolizer/node.js View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
bgeron
Please take a look.
4 years, 4 months ago (2016-08-09 13:48:03 UTC) #2
danno
https://codereview.chromium.org/2225683009/diff/1/src/compiler/graph-visualizer.cc File src/compiler/graph-visualizer.cc (right): https://codereview.chromium.org/2225683009/diff/1/src/compiler/graph-visualizer.cc#newcode158 src/compiler/graph-visualizer.cc:158: os_ << ",\"opinfo\":\"" << node->op()->ValueInputCount() << " v " ...
4 years, 4 months ago (2016-08-09 13:53:50 UTC) #3
Jarin
src/compiler/* lgtm https://codereview.chromium.org/2225683009/diff/1/src/compiler/operator.h File src/compiler/operator.h (right): https://codereview.chromium.org/2225683009/diff/1/src/compiler/operator.h#newcode54 src/compiler/operator.h:54: #define OP_PROP_LIST(V) \ OP_PROP_LIST -> OPERATOR_PROPERTY_LIST?
4 years, 4 months ago (2016-08-09 14:08:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225683009/20001
4 years, 4 months ago (2016-08-09 15:20:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 15:45:39 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 15:45:50 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a57b243c0fa4d66726d30f796999610e8fb1d33a
Cr-Commit-Position: refs/heads/master@{#38500}

Powered by Google App Engine
This is Rietveld 408576698