Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2226163002: DevTools: do not use string templates in front-end, minifier is confused. (Closed)

Created:
4 years, 4 months ago by pfeldman
Modified:
4 years, 4 months ago
Reviewers:
paulirish
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not use string templates in front-end, minifier is confused. R=paulirish BUG=623983 Committed: https://crrev.com/79df4803990d12f67cbaba6d912673d163baac12 Cr-Commit-Position: refs/heads/master@{#410842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
pfeldman
4 years, 4 months ago (2016-08-09 00:13:51 UTC) #1
paulirish
lgtm
4 years, 4 months ago (2016-08-09 01:11:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226163002/1
4 years, 4 months ago (2016-08-09 01:12:06 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/179994) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-09 01:19:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226163002/1
4 years, 4 months ago (2016-08-09 21:36:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 21:52:54 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/79df4803990d12f67cbaba6d912673d163baac12 Cr-Commit-Position: refs/heads/master@{#410842}
4 years, 4 months ago (2016-08-09 21:54:54 UTC) #14
paulirish
4 years, 4 months ago (2016-08-09 22:46:22 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2224173005/ by paulirish@chromium.org.

The reason for reverting is: https://codereview.chromium.org/2229683002 landed
so we don't need this any longer.

Powered by Google App Engine
This is Rietveld 408576698