Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2229683002: [Devtools] Fix RJSMIN for backtick (Closed)

Created:
4 years, 4 months ago by allada
Modified:
4 years, 4 months ago
Reviewers:
lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fix RJSMIN for backtick Fixed RJSMin for backtick string templates not compiling when space was present at end of backtrick string. BUG=623983 Committed: https://crrev.com/111e5134f9b68baf3c1a67ed5732b3de1de2048c Cr-Commit-Position: refs/heads/master@{#410572}

Patch Set 1 : [Devtools] Fix RJSMIN #

Patch Set 2 : [Devtools] Fix RJSMIN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters-internals.html View 1 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters-internals-expected.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/rjsmin.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
allada
PTL
4 years, 4 months ago (2016-08-09 02:13:17 UTC) #3
lushnikov
lgtm let's bake this in canary for a while before merging.
4 years, 4 months ago (2016-08-09 02:16:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229683002/40001
4 years, 4 months ago (2016-08-09 02:20:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-09 04:15:53 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 04:17:15 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/111e5134f9b68baf3c1a67ed5732b3de1de2048c
Cr-Commit-Position: refs/heads/master@{#410572}

Powered by Google App Engine
This is Rietveld 408576698