Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3192)

Unified Diff: blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc

Issue 2226143002: Gets rid of the LocationArbitrator interface, in preference for LocationProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: In response to Wez's #73-75 comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc
diff --git a/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc b/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc
index 1e944c6219695f68767316020fc583116f1a4bda..8258c99db45c7f4f78fb8607a00186b15d8bcbd7 100644
--- a/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc
+++ b/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc
@@ -106,30 +106,15 @@ TEST_F(BlimpLocationProviderTest, LocationProviderDeleted) {
location_provider_.reset();
}
-TEST_F(BlimpLocationProviderTest, RequestRefreshRunsCorrectly) {
- EXPECT_CALL(*delegate_, RequestRefresh()).Times(1);
-
- location_provider_->StartProvider(true);
- location_provider_->RequestRefresh();
-}
-
-TEST_F(BlimpLocationProviderTest, RequestRefreshHandlesNullDelegate) {
- EXPECT_CALL(*delegate_, RequestRefresh()).Times(0);
-
- location_provider_->StartProvider(true);
- delegate_.reset();
- location_provider_->RequestRefresh();
-}
-
-TEST_F(BlimpLocationProviderTest, OnPermissionGrantedCallsRefresh) {
- EXPECT_CALL(*delegate_, RequestRefresh()).Times(1);
+TEST_F(BlimpLocationProviderTest, OnPermissionGranted) {
+ EXPECT_CALL(*delegate_, OnPermissionGranted()).Times(1);
location_provider_->StartProvider(true);
location_provider_->OnPermissionGranted();
}
TEST_F(BlimpLocationProviderTest, OnPermissionGrantedHandlesNullDelegate) {
- EXPECT_CALL(*delegate_, RequestRefresh()).Times(0);
+ EXPECT_CALL(*delegate_, OnPermissionGranted()).Times(0);
location_provider_->StartProvider(true);
delegate_.reset();

Powered by Google App Engine
This is Rietveld 408576698