Issue 2226133003: Rename the app banner variations key for total site engagement score.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2226133003: Rename the app banner variations key for total site engagement score. (Closed)

Created:
4 years, 4 months ago by dominickn

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Rename the app banner variations key for total site engagement score. This change avoids a conflict between non-site engagement and site engagement banner triggering whilst we are transitioning from the former to the latter. BUG=616322 Review-Url: https://codereview.chromium.org/2216073003 Cr-Commit-Position: refs/heads/master@{#409997} (cherry picked from commit f9c4f230b41dd5372df376f43bb753bdf5989253) Committed: https://chromium.googlesource.com/chromium/src/+/31498da138c05bff551d963a0738ef3440c0b102

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/banners/app_banner_settings_helper.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

dominickn

4 years, 4 months ago (2016-08-09 01:37:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
31498da138c05bff551d963a0738ef3440c0b102 (tree was closed).