Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2216073003: Rename the app banner variations key for total site engagement score. (Closed)

Created:
4 years, 4 months ago by dominickn
Modified:
4 years, 4 months ago
Reviewers:
benwells
CC:
chromium-reviews, dominickn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename the app banner variations key for total site engagement score. This change avoids a conflict between non-site engagement and site engagement banner triggering whilst we are transitioning from the former to the latter. BUG=616322 Committed: https://crrev.com/f9c4f230b41dd5372df376f43bb753bdf5989253 Cr-Commit-Position: refs/heads/master@{#409997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/banners/app_banner_settings_helper.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
dominickn
PTAL thanks!
4 years, 4 months ago (2016-08-05 04:53:15 UTC) #4
benwells
lgtm, but as discussed I think the way we are experimenting is very scary, as ...
4 years, 4 months ago (2016-08-05 05:21:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216073003/1
4 years, 4 months ago (2016-08-05 05:37:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 05:44:07 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 05:46:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9c4f230b41dd5372df376f43bb753bdf5989253
Cr-Commit-Position: refs/heads/master@{#409997}

Powered by Google App Engine
This is Rietveld 408576698