Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2226103002: PPC/s390: Implement VisitFloat32Neg/VisitFloat64Neg and instr lcebr for s390 (Closed)

Created:
4 years, 4 months ago by JaideepBajwa
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Implement VisitFloat32Neg/VisitFloat64Neg and instr lcebr for s390 Implemented instruction selector functions VisitFloat32Neg/VisitFloat64Neg for s390 and ppc. For s390 implemented instruction lcebr to load complement for floatregisters. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/aa9b7b7683be97c0f09e191cb72b29a1f27efbdf Cr-Commit-Position: refs/heads/master@{#38466}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -7 lines) Patch
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/s390/instruction-codes-s390.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/s390/instruction-scheduler-s390.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/s390/assembler-s390.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/s390/assembler-s390.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/s390/disasm-s390.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/s390/simulator-s390.cc View 3 chunks +29 lines, -3 lines 1 comment Download

Messages

Total messages: 12 (4 generated)
JaideepBajwa
PTAL
4 years, 4 months ago (2016-08-08 22:01:33 UTC) #1
john.yan
lgtm
4 years, 4 months ago (2016-08-08 22:51:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226103002/1
4 years, 4 months ago (2016-08-08 23:58:59 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/12112) v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-09 00:34:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226103002/1
4 years, 4 months ago (2016-08-09 01:02:11 UTC) #8
john.yan
https://codereview.chromium.org/2226103002/diff/1/src/s390/simulator-s390.cc File src/s390/simulator-s390.cc (right): https://codereview.chromium.org/2226103002/diff/1/src/s390/simulator-s390.cc#newcode8538 src/s390/simulator-s390.cc:8538: set_d_register_from_double(r1, db_val); I guess we need to set the ...
4 years, 4 months ago (2016-08-09 02:24:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 06:46:59 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 06:49:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa9b7b7683be97c0f09e191cb72b29a1f27efbdf
Cr-Commit-Position: refs/heads/master@{#38466}

Powered by Google App Engine
This is Rietveld 408576698