PPC/s390: Implement VisitFloat32Neg/VisitFloat64Neg and instr lcebr for s390

src/s390/simulator-s390.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdarg.h>
 #include <stdlib.h>
 #include <cmath>
 
 #if V8_TARGET_ARCH_S390
 
@@ skipping 4136 matching lines @@
     case CDGBR:
     case CEGBR:
     case CGEBR:
     case CFDBR:
     case CGDBR:
     case SQDBR:
     case SQEBR:
     case CFEBR:
     case CEFBR:
     case LCDBR:
+    case LCEBR:
     case LPDBR:
     case LPEBR: {
       RREInstruction* rreInstr = reinterpret_cast<RREInstruction*>(instr);
       int r1 = rreInstr->R1Value();
       int r2 = rreInstr->R2Value();
       double r1_val = get_double_from_d_register(r1);
       double r2_val = get_double_from_d_register(r2);
       float fr1_val = get_float32_from_d_register(r1);
       float fr2_val = get_float32_from_d_register(r2);
       if (op == ADBR) {
@@ skipping 86 matching lines @@
         set_d_register_from_double(r1, r1_val);
         if (r2_val != r2_val) {  // input is NaN
           condition_reg_ = CC_OF;
         } else if (r2_val == 0) {
           condition_reg_ = CC_EQ;
         } else if (r2_val < 0) {
           condition_reg_ = CC_LT;
         } else if (r2_val > 0) {
           condition_reg_ = CC_GT;
         }
+      } else if (op == LCEBR) {
+        fr1_val = -fr2_val;
+        set_d_register_from_float32(r1, fr1_val);
+        if (fr2_val != fr2_val) {  // input is NaN
+          condition_reg_ = CC_OF;
+        } else if (fr2_val == 0) {
+          condition_reg_ = CC_EQ;
+        } else if (fr2_val < 0) {
+          condition_reg_ = CC_LT;
+        } else if (fr2_val > 0) {
+          condition_reg_ = CC_GT;
+        }
       } else if (op == LPDBR) {
         r1_val = std::fabs(r2_val);
         set_d_register_from_double(r1, r1_val);
         if (r2_val != r2_val) {  // input is NaN
           condition_reg_ = CC_OF;
         } else if (r2_val == 0) {
           condition_reg_ = CC_EQ;
         } else {
           condition_reg_ = CC_GT;
         }
@@ skipping 4219 matching lines @@
   DCHECK_OPCODE(LTEBR);
   DECODE_RRE_INSTRUCTION(r1, r2);
   int64_t r2_val = get_d_register(r2);
   float fr2_val = get_float32_from_d_register(r2);
   SetS390ConditionCode<float>(fr2_val, 0.0);
   set_d_register(r1, r2_val);
   return length;
 }
 
 EVALUATE(LCEBR) {
-  UNIMPLEMENTED();
-  USE(instr);
-  return 0;
+  DCHECK_OPCODE(LCEBR);
+  DECODE_RRE_INSTRUCTION(r1, r2);
+  float fr1_val = get_float32_from_d_register(r1);
+  float fr2_val = get_float32_from_d_register(r2);
+  fr1_val = -fr2_val;
+  set_d_register_from_float32(r1, fr1_val);
+  if (fr2_val != fr2_val) {  // input is NaN
+    condition_reg_ = CC_OF;
+  } else if (fr2_val == 0) {
+    condition_reg_ = CC_EQ;
+  } else if (fr2_val < 0) {
+    condition_reg_ = CC_LT;
+  } else if (fr2_val > 0) {
+    condition_reg_ = CC_GT;
+  }
+  return length;
 }
 
 EVALUATE(LDEBR) {
   DCHECK_OPCODE(LDEBR);
   DECODE_RRE_INSTRUCTION(r1, r2);
   float fp_val = get_float32_from_d_register(r2);
   double db_val = static_cast<double>(fp_val);
   set_d_register_from_double(r1, db_val);

[john.yan, 2016/08/09 02:24:03]

I guess we need to set the condition code for this too?

   return length;
 }
 
 EVALUATE(LXDBR) {
   UNIMPLEMENTED();
   USE(instr);
   return 0;
 }
 
 EVALUATE(LXEBR) {
@@ skipping 4036 matching lines @@
   return 0;
 }
 
 #undef EVALUATE
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // USE_SIMULATOR
 #endif  // V8_TARGET_ARCH_S390