Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2226053002: [wasm] Remove single function JIT support. (Closed)

Created:
4 years, 4 months ago by bradnelson
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove single function JIT support. While we might at some point want to explore if this is a win versus whole modules, for now we have the Tables interface planned. R=titzer@chromium.org,ahaas@chromium.org,mtrofin@chromium.org,rossberg@chromium.org BUG=v8:5044 Committed: https://crrev.com/1c5c526b904a89dc3ba1ecbf547c3bf939eedefd Cr-Commit-Position: refs/heads/master@{#38461}

Patch Set 1 #

Patch Set 2 : Drop test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -380 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 chunk +0 lines, -97 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-wasm.cc View 1 chunk +0 lines, -77 lines 0 comments Download
M src/wasm/ast-decoder.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/wasm/ast-decoder.cc View 5 chunks +0 lines, -45 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 2 chunks +1 line, -5 lines 0 comments Download
D test/mjsunit/wasm/default-func-call.js View 1 1 chunk +0 lines, -56 lines 0 comments Download
D test/mjsunit/wasm/jit-single-function.js View 1 chunk +0 lines, -79 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
bradnelson
4 years, 4 months ago (2016-08-08 20:35:52 UTC) #3
Mircea Trofin
On 2016/08/08 20:35:52, bradnelson wrote: lgtm
4 years, 4 months ago (2016-08-08 20:39:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226053002/20001
4 years, 4 months ago (2016-08-08 21:46:06 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-08 21:47:51 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 21:50:22 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c5c526b904a89dc3ba1ecbf547c3bf939eedefd
Cr-Commit-Position: refs/heads/master@{#38461}

Powered by Google App Engine
This is Rietveld 408576698