Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: src/wasm/ast-decoder.cc

Issue 2226053002: [wasm] Remove single function JIT support. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Drop test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/ast-decoder.h ('k') | src/wasm/module-decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/ast-decoder.cc
diff --git a/src/wasm/ast-decoder.cc b/src/wasm/ast-decoder.cc
index d797120274a49d9940ffa18973891e1027157ad5..28723c5fa6ae3410bdaf66d14ef684fe188c5c63 100644
--- a/src/wasm/ast-decoder.cc
+++ b/src/wasm/ast-decoder.cc
@@ -192,23 +192,6 @@ class WasmDecoder : public Decoder {
return false;
}
- inline bool Complete(const byte* pc, JITSingleFunctionOperand& operand) {
- ModuleEnv* m = module_;
- if (m && m->module && operand.sig_index < m->module->signatures.size()) {
- operand.sig = m->module->signatures[operand.sig_index];
- return true;
- }
- return false;
- }
-
- inline bool Validate(const byte* pc, JITSingleFunctionOperand& operand) {
- if (Complete(pc, operand)) {
- return true;
- }
- error(pc, pc + 1, "invalid signature index");
- return false;
- }
-
inline bool Validate(const byte* pc, BreakDepthOperand& operand,
ZoneVector<Control>& control) {
if (operand.arity > 1) {
@@ -303,8 +286,6 @@ class WasmDecoder : public Decoder {
ReturnArityOperand operand(this, pc);
return operand.arity;
}
- case kExprJITSingleFunction:
- return 3;
#define DECLARE_OPCODE_CASE(name, opcode, sig) \
case kExpr##name: \
@@ -358,10 +339,6 @@ class WasmDecoder : public Decoder {
return 1 + operand.length;
}
- case kExprJITSingleFunction: {
- JITSingleFunctionOperand operand(this, pc);
- return 1 + operand.length;
- }
case kExprSetLocal:
case kExprGetLocal: {
LocalIndexOperand operand(this, pc);
@@ -1027,21 +1004,6 @@ class WasmFullDecoder : public WasmDecoder {
break;
}
}
- case kExprJITSingleFunction: {
- if (FLAG_wasm_jit_prototype) {
- JITSingleFunctionOperand operand(this, pc_);
- if (Validate(pc_, operand)) {
- Value index = Pop(2, kAstI32);
- Value length = Pop(1, kAstI32);
- Value base = Pop(0, kAstI32);
- TFNode* call =
- BUILD(JITSingleFunction, base.node, length.node, index.node,
- operand.sig_index, operand.sig, position());
- Push(kAstI32, call);
- break;
- }
- }
- }
default:
error("Invalid opcode");
return;
@@ -1677,13 +1639,6 @@ bool PrintAst(base::AccountingAllocator* allocator, const FunctionBody& body,
}
break;
}
- case kExprJITSingleFunction: {
- JITSingleFunctionOperand operand(&i, i.pc());
- if (decoder.Complete(i.pc(), operand)) {
- os << " // sig #" << operand.sig_index << ": " << *operand.sig;
- }
- break;
- }
case kExprReturn: {
ReturnArityOperand operand(&i, i.pc());
os << " // arity=" << operand.arity;
« no previous file with comments | « src/wasm/ast-decoder.h ('k') | src/wasm/module-decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698