Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2226043002: Underline truncated text correctly in a contrary flow (Closed)

Created:
4 years, 4 months ago by rhogan
Modified:
4 years, 4 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@634404
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Underline truncated text correctly in a contrary flow BUG=634445 Committed: https://crrev.com/30b1157934288f2efe1a8e3a00acedc6506fb8ee Cr-Commit-Position: refs/heads/master@{#410832}

Patch Set 1 #

Patch Set 2 : bug 634445 #

Patch Set 3 : bug 634445 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-ltr-text-in-ltr-flow-underline.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-ltr-text-in-rtl-flow-underline.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-rtl-text-in-ltr-flow-underline.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-rtl-text-in-rtl-flow-underline.html View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-strict-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-ltr-flow-underline-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-ltr-flow-underline-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-rtl-flow-underline-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-rtl-flow-underline-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 2 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
rhogan
4 years, 4 months ago (2016-08-09 20:29:21 UTC) #8
eae
LGTM
4 years, 4 months ago (2016-08-09 20:30:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226043002/40001
4 years, 4 months ago (2016-08-09 21:33:17 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-09 21:38:03 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 21:39:21 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/30b1157934288f2efe1a8e3a00acedc6506fb8ee
Cr-Commit-Position: refs/heads/master@{#410832}

Powered by Google App Engine
This is Rietveld 408576698