Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

Issue 2226043002: Underline truncated text correctly in a contrary flow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@634404
Patch Set: bug 634445 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
index 7203c81180e8718d477f557fa9fba74c8e3ca550..b44064a3cba28dc37cf5bfd4015efbe98c0d6042 100644
--- a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
@@ -715,10 +715,12 @@ void InlineTextBoxPainter::paintDecoration(const PaintInfo& paintInfo, const Lay
LayoutUnit width = m_inlineTextBox.logicalWidth();
if (m_inlineTextBox.truncation() != cNoTruncation) {
- width = LayoutUnit(m_inlineTextBox.getLineLayoutItem().width(
- m_inlineTextBox.start(), m_inlineTextBox.truncation(), m_inlineTextBox.textPos(),
- m_inlineTextBox.isLeftToRightDirection() ? LTR : RTL, m_inlineTextBox.isFirstLineStyle()));
- if (!m_inlineTextBox.isLeftToRightDirection())
+ bool ltr = m_inlineTextBox.isLeftToRightDirection();
+ bool flowIsLTR = m_inlineTextBox.getLineLayoutItem().style()->isLeftToRightDirection();
+ width = LayoutUnit(m_inlineTextBox.getLineLayoutItem().width(ltr == flowIsLTR ? m_inlineTextBox.start() : m_inlineTextBox.truncation(),
+ ltr == flowIsLTR ? m_inlineTextBox.truncation() : m_inlineTextBox.len() - m_inlineTextBox.truncation(), m_inlineTextBox.textPos(),
+ flowIsLTR ? LTR : RTL, m_inlineTextBox.isFirstLineStyle()));
+ if (!flowIsLTR)
localOrigin.move(m_inlineTextBox.logicalWidth() - width, LayoutUnit());
}
@@ -775,6 +777,7 @@ void InlineTextBoxPainter::paintCompositionUnderline(GraphicsContext& context, c
unsigned paintStart = underlinePaintStart(underline);
unsigned paintEnd = underlinePaintEnd(underline);
+ // TODO(crbug.com/636060): Handle mixed-flow contexts correctly.
// start of line to draw
float start = paintStart == static_cast<unsigned>(m_inlineTextBox.start()) ? 0 :
m_inlineTextBox.getLineLayoutItem().width(m_inlineTextBox.start(), paintStart - m_inlineTextBox.start(), m_inlineTextBox.textPos(), m_inlineTextBox.isLeftToRightDirection() ? LTR : RTL, m_inlineTextBox.isFirstLineStyle());
« no previous file with comments | « third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698