Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2225903002: arc: Implement proper Arc window activation for task moving to front. (Closed)

Created:
4 years, 4 months ago by khmel
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

arc: Implement proper Arc window activation for task moving to front. This handles new Android onTaskMovedToFront notification and activates corresponded window. NOTRY=true NOPRESUBMIT=true TBR=reviewer@chromium.org BUG=b/28223322 TEST=Manually on device. Start new task, its window gets active. Start Arc app and activate native chrome window, then start task again via app list and corresponded Arc window gets active. Start one Arc app, start native Chrome app, start another Arc app. Close last Arc app and native Chrome window gets active. Review-Url: https://codereview.chromium.org/2184103003 Cr-Commit-Position: refs/heads/master@{#409126} (cherry picked from commit 62b40ce1cf15e419d7f9807202b93fc754db7609)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -7 lines) Patch
M components/exo/shell_surface.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/exo/shell_surface.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M components/exo/wayland/server.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h View 3 chunks +17 lines, -0 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/wayland-protocols/protocol/remote-shell-protocol.c View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225903002/1
4 years, 4 months ago (2016-08-08 15:13:00 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-08 15:13:02 UTC) #4
Luis Héctor Chávez
lgtm
4 years, 4 months ago (2016-08-08 15:15:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225903002/1
4 years, 4 months ago (2016-08-08 15:15:40 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 4 months ago (2016-08-08 15:15:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225903002/1
4 years, 4 months ago (2016-08-08 15:19:43 UTC) #13
commit-bot: I haz the power
Failed to commit the patch.
4 years, 4 months ago (2016-08-08 15:22:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225903002/1
4 years, 4 months ago (2016-08-08 15:34:59 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 15:36:59 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698