arc: Implement proper Arc window activation for task moving to front.

arc: Implement proper Arc window activation for task moving to front.

This handles new Android onTaskMovedToFront notification and activates
corresponded window.

BUG=b/28223322
TEST=Manually on device. Start new task, its window gets active.
     Start Arc app and activate native chrome window, then start
     task again via app list and corresponded Arc window gets
     active. Start one Arc app, start native Chrome app, start
     another Arc app. Close last Arc app and native Chrome window
     gets active.

Committed: https://crrev.com/62b40ce1cf15e419d7f9807202b93fc754db7609
Cr-Commit-Position: refs/heads/master@{#409126}

[khmel, 2016-07-27 23:42:10]

khmel@chromium.org changed reviewers:
+ reveman@chromium.org, skuhne@chromium.org

[khmel, 2016-07-27 23:42:10]

Hi David and Stefan,

There Android side CL also: ag/1263283

PTAL

[Mr4D (OOO till 08-26), 2016-07-28 00:52:00]

lgtm

[khmel, 2016-07-28 14:54:20]

khmel@chromium.org changed reviewers:
+ rickyz@chromium.org, xiyuan@chromium.org

[khmel, 2016-07-28 14:54:20]

Thank you Stefan for review!

Adding Ricky (components/arc/common/app.mojom) and Xiyuan
(	chrome/browser/ui/app_list/arc/arc_app_list_prefs.*)


PTAL

[reveman, 2016-07-28 14:54:59]

reveman@chromium.org changed reviewers:
- rickyz@chromium.org, xiyuan@chromium.org

[reveman, 2016-07-28 14:55:00]

https://codereview.chromium.org/2184103003/diff/1/components/arc/common/app.m...
File components/arc/common/app.mojom (right):

https://codereview.chromium.org/2184103003/diff/1/components/arc/common/app.m...
components/arc/common/app.mojom:104: [MinVersion=13] OnTaskMovedToFront@13(int32
task_id);
I think this needs to go through the wayland channel as part of the remote shell
interface. We already have messages there that provides the reverse; tell
android to move a task to front as a result of chrome and the user activating a
window. Having two different channels for these type of messages make it
difficult to handle them in the correct order.

Using the wayland interface also makes it easy to add a serial number to the
request that can be used in the future for focus stealing prevention.

[khmel, 2016-07-28 15:13:27]

https://codereview.chromium.org/2184103003/diff/1/components/arc/common/app.m...
File components/arc/common/app.mojom (right):

https://codereview.chromium.org/2184103003/diff/1/components/arc/common/app.m...
components/arc/common/app.mojom:104: [MinVersion=13] OnTaskMovedToFront@13(int32
task_id);
On 2016/07/28 14:55:00, reveman wrote:
> I think this needs to go through the wayland channel as part of the remote
shell
> interface. We already have messages there that provides the reverse; tell
> android to move a task to front as a result of chrome and the user activating
a
> window. Having two different channels for these type of messages make it
> difficult to handle them in the correct order.
> 
> Using the wayland interface also makes it easy to add a serial number to the
> request that can be used in the future for focus stealing prevention.

Ok, will try to use wayland service for this task.

[reveman, 2016-07-28 15:31:53]

On 2016/07/28 at 15:13:27, khmel wrote:
>
https://codereview.chromium.org/2184103003/diff/1/components/arc/common/app.m...
> File components/arc/common/app.mojom (right):
> 
>
https://codereview.chromium.org/2184103003/diff/1/components/arc/common/app.m...
> components/arc/common/app.mojom:104: [MinVersion=13]
OnTaskMovedToFront@13(int32 task_id);
> On 2016/07/28 14:55:00, reveman wrote:
> > I think this needs to go through the wayland channel as part of the remote
shell
> > interface. We already have messages there that provides the reverse; tell
> > android to move a task to front as a result of chrome and the user
activating a
> > window. Having two different channels for these type of messages make it
> > difficult to handle them in the correct order.
> > 
> > Using the wayland interface also makes it easy to add a serial number to the
> > request that can be used in the future for focus stealing prevention.
> 
> Ok, will try to use wayland service for this task.

Thanks. Here's a basic example of adding new remote-shell requests:
https://codereview.chromium.org/2061763002

Ping me if you have questions.

[khmel, 2016-07-28 22:06:16]

On 2016/07/28 15:31:53, reveman wrote:
> On 2016/07/28 at 15:13:27, khmel wrote:
> >
>
https://codereview.chromium.org/2184103003/diff/1/components/arc/common/app.m...
> > File components/arc/common/app.mojom (right):
> > 
> >
>
https://codereview.chromium.org/2184103003/diff/1/components/arc/common/app.m...
> > components/arc/common/app.mojom:104: [MinVersion=13]
> OnTaskMovedToFront@13(int32 task_id);
> > On 2016/07/28 14:55:00, reveman wrote:
> > > I think this needs to go through the wayland channel as part of the remote
> shell
> > > interface. We already have messages there that provides the reverse; tell
> > > android to move a task to front as a result of chrome and the user
> activating a
> > > window. Having two different channels for these type of messages make it
> > > difficult to handle them in the correct order.
> > > 
> > > Using the wayland interface also makes it easy to add a serial number to
the
> > > request that can be used in the future for focus stealing prevention.
> > 
> > Ok, will try to use wayland service for this task.
> 
> Thanks. Here's a basic example of adding new remote-shell requests:
> https://codereview.chromium.org/2061763002
> 
> Ping me if you have questions.

Thanks David for useful links,

PTAL

[reveman, 2016-08-01 00:40:14]

lgtm

[reveman, 2016-08-01 00:52:41]

https://codereview.chromium.org/2184103003/diff/20001/third_party/wayland-pro...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2184103003/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:475:
<request name="activate" since="9">
Oh, one thing. Can you add:

<arg name="serial" type="uint" summary="the serial of the user event"/>

the client side code can just past the serial of the last input event or 0. and
the exo code can just ignore it for now but it allows us to implement focus
stealing prevention in the near future without having to update the interface.

[reveman, 2016-08-02 00:30:14]

fyi, this needs to be rebased on https://codereview.chromium.org/2189073003/

[khmel, 2016-08-02 02:21:39]

The CQ bit was checked by khmel@chromium.org

[khmel, 2016-08-02 02:21:39]

The patchset sent to the CQ was uploaded after l-g-t-m from skuhne@chromium.org,
reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2184103003/#ps60001
(title: "fix rebase")

[khmel, 2016-08-02 02:21:53]

https://codereview.chromium.org/2184103003/diff/20001/third_party/wayland-pro...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2184103003/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:475:
<request name="activate" since="9">
On 2016/08/01 00:52:41, reveman wrote:
> Oh, one thing. Can you add:
> 
> <arg name="serial" type="uint" summary="the serial of the user event"/>
> 
> the client side code can just past the serial of the last input event or 0.
and
> the exo code can just ignore it for now but it allows us to implement focus
> stealing prevention in the near future without having to update the interface.

Thanks David for offline chat, done

[commit-bot: I haz the power, 2016-08-02 02:21:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 03:00:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-02 03:01:47]

Description was changed from

==========
arc: Implement proper Arc window activation for task moving to front.

This handles new Android onTaskMovedToFront notification and activates
corresponded window.

BUG=b/28223322
TEST=Manually on device. Start new task, its window gets active.
     Start Arc app and activate native chrome window, then start
     task again via app list and corresponded Arc window gets
     active. Start one Arc app, start native Chrome app, start
     another Arc app. Close last Arc app and native Chrome window
     gets active.
==========

to

==========
arc: Implement proper Arc window activation for task moving to front.

This handles new Android onTaskMovedToFront notification and activates
corresponded window.

BUG=b/28223322
TEST=Manually on device. Start new task, its window gets active.
     Start Arc app and activate native chrome window, then start
     task again via app list and corresponded Arc window gets
     active. Start one Arc app, start native Chrome app, start
     another Arc app. Close last Arc app and native Chrome window
     gets active.

Committed: https://crrev.com/62b40ce1cf15e419d7f9807202b93fc754db7609
Cr-Commit-Position: refs/heads/master@{#409126}
==========

[commit-bot: I haz the power, 2016-08-02 03:01:49]

Patchset 4 (id:??) landed as
https://crrev.com/62b40ce1cf15e419d7f9807202b93fc754db7609
Cr-Commit-Position: refs/heads/master@{#409126}